Aria-label everywhere

belinde · Apr 17, 2024 · 66b1097 · 66b1097
1 parent 8ef5c8c
commit 66b1097
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 2 deletions.
diff --git a/src/components/InitialNoteForm/NoteSelector.tsx b/src/components/InitialNoteForm/NoteSelector.tsx
@@ -55,6 +55,7 @@ export const NoteSelector: FC<{
               key={n}
               icon={`numeric-${n}`}
               value={n.toString()}
+              aria-label={n.toString()}
               accessibilityLabel={n.toString()}
             />
           ))}
@@ -77,6 +78,7 @@ export const NoteSelector: FC<{
               key={n}
               value={n}
               label={noteName(n)}
+              aria-label={noteName(n)}
               accessibilityLabel={noteName(n)}
             />
           ))}

diff --git a/src/components/Page.tsx b/src/components/Page.tsx
@@ -12,6 +12,7 @@ export const Page: FC<{
   return (
     <View
       accessible
+      aria-label={props.accessibilityLabel}
       accessibilityLabel={props.accessibilityLabel}
       style={{
         flex: 1,

diff --git a/src/components/SongForm/SongInitialNotesManagement.tsx b/src/components/SongForm/SongInitialNotesManagement.tsx
@@ -62,6 +62,7 @@ export const SongInitialNotesManagement: FC<{
         renderAction={(note) => (
           <IconButton
             icon="pencil"
+            aria-label="Modifica nota iniziale"
             accessibilityLabel="Modifica nota iniziale"
             onPress={() => {
               setCanChange(false);

diff --git a/src/components/SongForm/SongTextInput.tsx b/src/components/SongForm/SongTextInput.tsx
@@ -26,6 +26,7 @@ export const SongTextInput: FC<{
         error={props.mandatory && !value}
         label={props.label}
         accessibilityLabel={props.label}
+        aria-label={props.label}
         value={value}
         onChangeText={onChangeText}
         multiline={props.multiline}

diff --git a/src/pages/Concert/ViewConcertMenu.tsx b/src/pages/Concert/ViewConcertMenu.tsx
@@ -22,6 +22,7 @@ export const ViewConcertMenu: FC = () => {
           icon="dots-vertical"
           onPress={() => setVisible(true)}
           accessibilityLabel="Azioni"
+          aria-label="Azioni"
         />
       }
       overlayAccessibilityLabel="Menu del concerto"
@@ -37,6 +38,7 @@ export const ViewConcertMenu: FC = () => {
         }}
         title="Modifica"
         accessibilityLabel="Modifica il concerto"
+        aria-label="Modifica il concerto"
       />
       <Menu.Item
         leadingIcon="delete"
@@ -65,6 +67,7 @@ export const ViewConcertMenu: FC = () => {
         }}
         title="Elimina"
         accessibilityLabel="Elimina il concerto dal repertorio"
+        aria-label="Elimina il concerto dal repertorio"
       />
     </Menu>
   );

diff --git a/src/pages/Library/ViewSongMenu.tsx b/src/pages/Library/ViewSongMenu.tsx
@@ -22,6 +22,7 @@ export const ViewSongMenu: FC = () => {
           icon="dots-vertical"
           onPress={() => setVisible(true)}
           accessibilityLabel="Azioni"
+          aria-label="Azioni"
         />
       }
       overlayAccessibilityLabel="Menu del pezzo"
@@ -37,6 +38,7 @@ export const ViewSongMenu: FC = () => {
         }}
         title="Modifica"
         accessibilityLabel="Modifica il pezzo"
+        aria-label="Modifica il pezzo"
       />
       <Menu.Item
         leadingIcon="delete"
@@ -65,6 +67,7 @@ export const ViewSongMenu: FC = () => {
         }}
         title="Elimina"
         accessibilityLabel="Elimina il pezzo"
+        aria-label="Elimina il pezzo"
       />
     </Menu>
   );

diff --git a/src/pages/Settings/Basic.tsx b/src/pages/Settings/Basic.tsx
@@ -42,11 +42,13 @@ export const Basic: FC = () => {
           value="latin"
           label="Do, Re, Mi..."
           accessibilityLabel="Do, Re, Mi..."
+          aria-label="Do, Re, Mi..."
         />
         <RadioButton.Item
           value="english"
-          label="A, B, C..."
-          accessibilityLabel="A, B, C..."
+          label="C, D, E..."
+          accessibilityLabel="C, D, E..."
+          aria-label="C, D, E..."
         />
       </RadioButton.Group>
 

diff --git a/src/pages/Settings/SectionSelector.tsx b/src/pages/Settings/SectionSelector.tsx
@@ -36,6 +36,7 @@ const SectionPart: FC<{
         onPress={() => props.toggle()}
         label={label}
         accessibilityLabel={label}
+        aria-label={label}
       />
     </View>
   );