-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Travertino to Toga repository #3086
Conversation
…/changelog stuff)
@freakboy3742 I'm not sure if you're waiting on this to do the new Toga release by any specific time, but in case you are, heads up that I'll have little to no free time for it in the next week or so. |
@HalfWhitt Thanks for the heads up. If the need for a 0.5 release becomes more pressing, we'll build on the work you've done here. |
Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
Ignoring the
Seems reasonable. |
That's fair. It's also going to look odd for most of the Travertino release notes to say "0.5.3 - no changes", as most Toga releases likely won't have Travertino fixes at all (based on historical cadence). If/when we ever extract Travertino into a standalone repo, the gap in the release notes will be odd; but there won't be any real trigger to do this until Colosseum (or similar) is viable - which also means there won't be any real version cross-project compatibility concerns until this happens, removing the real value of having an independent set of change notes. So - lets go with:
|
Is that instead of or in addition to adding those changes (or at least ones relevant to Toga users) in Toga's 0.5.0 changes? ...Now that I think about, I have no idea if it's even possible to tell Towncrier to link notes to PRs in another repository. Maybe that's trouble than it's worth. |
No - I'm thinking of the documentation of Travertino 0.5.0 as if it were generated from the Travertino repo. The features that have been migrated in this PR were all developed "over there". Going forward, we only have Toga changenotes for Travertino features. |
Okay, I think I've addressed everything:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a couple of minor tweaks, including promoting the release note to FEATURE, since it's a major change worth note - but I've also included a TODO in that feature which will act as a reminder when I draft the final Toga 0.5.0 release notes.
Otherwise this looks great! Thanks for all the work on this (and all the Travertino fixes that have made this change something worth doing!)
And thank you for the cleanup tweaks! I've already got ideas bubbling for more things to improve in Travertino, and it'll be so much easier to do now. 😄 |
Fixes beeware/travertino#246
PR Checklist: