Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1876] fix: Adds app name character escaping #96

Merged
merged 5 commits into from
Nov 27, 2024
Merged

[1876] fix: Adds app name character escaping #96

merged 5 commits into from
Nov 27, 2024

Conversation

Sharealikelicence
Copy link

@Sharealikelicence Sharealikelicence commented Nov 26, 2024 •
edited by freakboy3742
Loading

Adds GradeEscape extension to app name usage.

  • User-entered data should be appropriately escaped in Gradle, rather than break the resulting template

Fixes beeware/briefcase#1876

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I hate it! :-)

But seriously - nice debugging work.

@freakboy3742 freakboy3742 merged commit 539a97e into beeware:main Nov 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor syntax bug when using quotes in the app's name
2 participants
@Sharealikelicence @freakboy3742