Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dependency list customizable. #82

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Make the dependency list customizable. #82

merged 9 commits into from
Jan 30, 2024

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Jan 17, 2024

Makes the list of libraries a templated variable, rather than a hard-coded list.

Removes the testImplementation and androidTestImplementation entries on the basis that Toga apps won't be using them.

Also makes the base theme configurable; this is needed because if you're using Material Components, you need to use a Material base theme, or most of your Material widget colors will default to Black.

Bumps the target SDK version to 34, so that we can use a recent version of Material Components.

Briefcase-Repo: https://github.com/freakboy3742/briefcase.git
Briefcase-Ref: android-libs

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith January 25, 2024 03:23
Copy link
Member

@mhsmith mhsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merging yet, because it'll break the main branch until beeware/briefcase#1610 is merged too.

@mhsmith mhsmith merged commit 97402d4 into main Jan 30, 2024
16 checks passed
@freakboy3742 freakboy3742 mentioned this pull request Jan 31, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants