[bug] use single-quotes for string literals in sqlite queries

beets/dbcore/query.py

@@ -303,7 +303,7 @@
         return unicodedata.normalize("NFC", s)
 
     @classmethod
     def string_match(cls, pattern: Pattern, value: str) -> bool:
         return pattern.search(cls._normalize(value)) is not None
 
 
@@ -465,7 +465,7 @@
         """Return a set with field names that this query operates on."""
         return reduce(or_, (sq.field_names for sq in self.subqueries))
 
     def __init__(self, subqueries: Sequence = ()):
         self.subqueries = subqueries
 
     # Act like a sequence.
@@ -476,7 +476,7 @@
     def __getitem__(self, key):
         return self.subqueries[key]
 
     def __iter__(self) -> Iterator:
         return iter(self.subqueries)
 
     def __contains__(self, subq) -> bool:
@@ -525,7 +525,7 @@
         """Return a set with field names that this query operates on."""
         return set(self.fields)
 
     def __init__(self, pattern, fields, cls: Type[FieldQuery]):
         self.pattern = pattern
         self.fields = fields
         self.query_class = cls
@@ -563,7 +563,7 @@
     query is initialized.
     """
 
     subqueries: MutableSequence
 
     def __setitem__(self, key, value):
         self.subqueries[key] = value
@@ -908,7 +908,7 @@
         """
         return None
 
     def sort(self, items: List) -> List:
         """Sort the list of objects and return a list."""
         return sorted(items)
 
@@ -1002,7 +1002,7 @@
         self.ascending = ascending
         self.case_insensitive = case_insensitive
 
     def sort(self, objs: Collection):
         # TODO: Conversion and null-detection here. In Python 3,
         # comparisons with None fail. We should also support flexible
         # attributes with different types without falling over.
@@ -1040,8 +1040,8 @@
         if self.case_insensitive:
             field = (
                 "(CASE "
-                'WHEN TYPEOF({0})="text" THEN LOWER({0}) '
-                'WHEN TYPEOF({0})="blob" THEN LOWER({0}) '
+                "WHEN TYPEOF({0})='text' THEN LOWER({0}) "
+                "WHEN TYPEOF({0})='blob' THEN LOWER({0}) "
                 "ELSE {0} END)".format(self.field)
             )
         else:
@@ -1061,7 +1061,7 @@
 class NullSort(Sort):
     """No sorting. Leave results unsorted."""
 
     def sort(self, items: List) -> List:
         return items
 
     def __nonzero__(self) -> bool:

beets/library.py

@@ -313,7 +313,7 @@ def order_clause(self):
         collate = "COLLATE NOCASE" if self.case_insensitive else ""
         return (
             "(CASE {0}_sort WHEN NULL THEN {0} "
-            'WHEN "" THEN {0} '
+            "WHEN '' THEN {0} "
             "ELSE {0}_sort END) {1} {2}"
         ).format(field, collate, order)
 

docs/changelog.rst

@@ -34,6 +34,7 @@ Bug fixes:
   as a numpy array. Update ``librosa`` dependency constraint to prevent similar
   issues in the future.
   :bug:`5289`
+* Fixed changed double to single quotes in two queries to work with DSQLITE_DQS=0.
 
 For packagers: