-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes TypeError in the Discogs plugin #5415
Conversation
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it with a release that has a couple of formats and I think we'd want to re-think the solution. Could you by any chance share the URL of the release that caused the issue?
@amogus07 can you please share the URL of the release that caused the failure you reported above, for testing? |
I don't have it, unfortunately |
I'm getting this error too. Here is one example. The result formats data is |
oh, so the problem occurs when description is empty? |
Here we go, that's amazing, thanks @mwean! I sensed that the description may have been |
now, someone needs to add a test case (idk how to do that) and this should be good to get merged, right? |
Indeed. I can help you with the test :) |
@amogus07 have just isolated this change into a separate method and added a test |
2f98344
to
e3e2796
Compare
e3e2796
to
fe642a7
Compare
Description
Fixes the following error:
IDK what exactly caused it, but this seems to have fixed it without causing additional problems.
To Do
Documentation.