Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is a gotcha where if you have validations that run before the
has_state_machine
call in a class definition, it will end up clearing out any existing errors on the object b/c we delegate theerrors
method to the object of the state instance andvalid?
clears any existing errors. This PR fixes this issue by removing the delegation and manually adding the errors to the object.Checklist
Merging
Please choose the type of release that is required for this change.