Rework the level API again. #121
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit isn't stable. No writes below Y 0 are saved into the world. To make this production ready. Fixing that bug, adding more tests, and adding some examples are needed
|
Have you tried loading the world with PM or Dragonfly? If there is an error they probably won't just swallow it |
I have not. Once i gain some motivation for this again i will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucy expressed her dislike of the new level API I created so i took it upon myself to make it easier to maintain and easier to reason about. I hope this new implementation will statisfy that goal. I would like any comments on things to change before a sink any more time into it though!
Right now this API isn't working since any writes below Y: 0 just aren't written to the database. So if anyone could point that error out too while looking at the code that would be fantastic lol. This API is fully sub chunk driven compared to the old one which was kind of both sub chunk and chunk driven.
Things I want to add