Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizing ColorPicker #1157

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Finalizing ColorPicker #1157

merged 2 commits into from
Dec 15, 2024

Conversation

diluculo
Copy link
Contributor

This PR completes the ColorPicker implementation with localization support:

  • Added localizations for text elements and labels
  • Added localizations for color display names
  • Updated More button style to match WinUI 3

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@diluculo
feat: Add more localization keys for ColorPicker
ea4f28f 
- Add valueSliderTooltip and alphaSliderTooltip localization keys
@diluculo
feat(ColorPicker): Apply localization to text, label and color displa…
d5e8b26 
…y names

- Update MoreButton style to match WinUI 3
@diluculo
Copy link
Contributor Author

ColorPicker preview

@bdlukaa bdlukaa merged commit ad8cad8 into bdlukaa:master Dec 15, 2024
3 checks passed
@diluculo diluculo deleted the localization branch December 16, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlukaa bdlukaa bdlukaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diluculo @bdlukaa