-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Spot SDK version from 4.1.0 to 4.1.1 #566
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
Pull Request Test Coverage Report for Build 13056971498Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let me know if you need help testing any of this on robot
bosdyn-msgs 4.1.0 | ||
bosdyn-spot-api-msgs 4.1.0 | ||
bosdyn-spot-cam-api-msgs 4.1.0 | ||
bosdyn-api 4.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the install script locally outside of the docker. for some reason my bosdyn-api
stayed on 4.1.0
while the rest of these packages got correctly upgraded to 4.1.1
? I fixed it by uninstalling and reinstalling bosdyn-api
with pip. everything else was installed successfully 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. That's weird. Where did all packages get installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my case it seems like bosdyn-api 4.1.1 was put into my dist-packages but 4.1.0 was in my site packages before i uninstalled 4.1.0. not sure how i ended up in this state, but it seems resolved now? this is the output from the install script if you're interested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual pip install
s will typically land packages in site. Bundled pip
dependencies land in dist because they are installed system-wide (just like the associated ROS 2 packages). Deep down, the issue is that pip
and apt
don't play ball with each other. Maybe you ended up pip install
ing bosdyn-api
a while back (maybe not explicitly, maybe it was in some requirements.txt
file) and it just stayed there.
Bump Spot SDK version from 4.1.0 to 4.1.1 (bdaiinstitute#566)
Change Overview
Precisely what the title says.
Testing Done
Manually tested several examples, available here and downstream, on Opal. At least that were safe to run in a tight spot. I'll run a few more early next week but all seems to indicate this patch is safe to go.
Edit: all examples tested on Nyla. Looks about right.