Gaddison/spot sdk examples conversion #564
Open
+648
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaddison-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai,
tcappellari-bdai and
khughes-bdai
as code owners
There was a problem hiding this comment.
overall looks great to me! Could you add to the readme with the command to run this example + a short description of what it does?
Also, to get CI to pass, in the repo root run pre-commit install then pre-commit run --all and this should fix it.
(you can also follow the steps from the dco log to fix that error: https://github.com/bdaiinstitute/spot_ros2/runs/36316801944)
Comment on lines
+181
to
+184
| try: | ||
| from cv_bridge import CvBridge | ||
| import cv2 | ||
| self.br = CvBridge() |
There was a problem hiding this comment.
I'm wondering if we should just put these at the top level import, as we are sort of enforcing that the user should have these packages by including them in the package.xml?
There was a problem hiding this comment.
ya i would just move those imports to the top
gaddison-bdai
force-pushed
the
gaddison/spot-sdk_examples_conversion
branch
from
5eccf8b to
56168d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Created
hello_spotin spot_examples to mirror that ofspot-sdk, as part of SW-1864.Compiled and behavior qualitatively verified on hardware.