Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] Add crouching stand service #562

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

llee-bdai
Copy link
Collaborator

Change Overview

Adding in a service to crouch (stand at the lowest height possible) Spot. This is needed to increase the reachable space closer to the ground :)

Copy link
Collaborator

I'm good with this change but just curious if you tried using the /body_pose topic? I haven't tried it on robot but it supposedly lets you move the height + orientation of the body at once.

def body_pose_callback(self, data: Pose) -> None:

Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im good with this addition

Copy link
Collaborator Author

@khughes-bdai it does work with /body_pose if you publish a Pose but I kind of wanted a trigger service for this. But I also completely understand if this is just more fluff that isn't needed, in which case I will use /body_pose

I'm not going to die on this crouch hill, just makes my life easier :)

Copy link
Collaborator

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good to know that body pose still works!

Copy link

@scastro-bdai scastro-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- wondering if it makes any logical sense to change this to a SetBool so you can set crouch to be true/false, but maybe this instead is a bunch of trigger services for e.g., stand, sit, crouch, etc.?

It also may be too late to consider this, but is there also an option to have a single service with a string payload that can triage the string contents to do things like sit, stand, etc.?

Copy link
Collaborator Author

llee-bdai commented Jan 22, 2025

@scastro-bdai the reason I kept it as a Trigger here is mostly to follow the convention of how the Spot driver has so far been written.

On the behavior stack side (where I intend to use this), it already is a string for sit or stand or crouch

@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12936140185

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 402 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 51.319%

Files with Coverage Reduction New Missed Lines %
spot_ros2/spot_ros2/spot_driver/spot_driver/spot_ros2.py 402 44.35%
Totals Coverage Status
Change from base Build 12896262982: -0.06%
Covered Lines: 1965
Relevant Lines: 3829

💛 - Coveralls

@llee-bdai llee-bdai force-pushed the ll/maple/add_crouch_service branch from 392fcc0 to 472490e Compare January 23, 2025 15:25
Copy link
Collaborator Author

llee-bdai commented Jan 23, 2025

Merge activity

  • Jan 23, 1:58 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 23, 1:59 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 23, 2:16 PM EST: Graphite couldn't merge this PR because it failed for an unknown reason.

Signed-off-by: Laura Lee <[email protected]>
Signed-off-by: Laura Lee <[email protected]>
Signed-off-by: Laura Lee <[email protected]>
@llee-bdai llee-bdai force-pushed the ll/maple/add_crouch_service branch from 472490e to e60cc6b Compare January 23, 2025 18:58
@llee-bdai llee-bdai merged commit 0528141 into main Jan 23, 2025
6 checks passed
@llee-bdai llee-bdai deleted the ll/maple/add_crouch_service branch January 23, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants