-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[N/A] Add crouching stand service #562
Conversation
I'm good with this change but just curious if you tried using the spot_ros2/spot_driver/spot_driver/spot_ros2.py Line 2506 in 24e2886
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im good with this addition
@khughes-bdai it does work with I'm not going to die on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good to know that body pose still works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- wondering if it makes any logical sense to change this to a SetBool
so you can set crouch to be true/false, but maybe this instead is a bunch of trigger services for e.g., stand, sit, crouch, etc.?
It also may be too late to consider this, but is there also an option to have a single service with a string payload that can triage the string contents to do things like sit, stand, etc.?
@scastro-bdai the reason I kept it as a On the behavior stack side (where I intend to use this), it already is a string for |
Pull Request Test Coverage Report for Build 12936140185Details
💛 - Coveralls |
392fcc0
to
472490e
Compare
Signed-off-by: Laura Lee <[email protected]>
Signed-off-by: Laura Lee <[email protected]>
Signed-off-by: Laura Lee <[email protected]>
472490e
to
e60cc6b
Compare
Change Overview
Adding in a service to crouch (stand at the lowest height possible) Spot. This is needed to increase the reachable space closer to the ground :)