[N/A] revert update_sigterm_sigkill_timeouts #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khughes-bdai
force-pushed
the
khughes/revert_sigterm_sigkill
branch
from
ec9bc35 to
03bfa8b
Compare
khughes-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai and
tcappellari-bdai
as code owners
khughes-bdai
changed the title
khughes-bdai
requested review from
a team,
mbrauckmann-bdai,
jcarpinelli-bdai,
bjin-bdai,
mgoh-bdai and
mvictora-bdai
Pull Request Test Coverage Report for Build 12752793843Details
💛 - Coveralls |
bjin-bdai
approved these changes
Jan 13, 2025
Signed-off-by: Katie Hughes <[email protected]>
khughes-bdai
force-pushed
the
khughes/revert_sigterm_sigkill
branch
from
03bfa8b to
800418f
Compare
khughes-bdai
added a commit
that referenced
this pull request
Jan 14, 2025
## Change Overview Reverts the calls to `update_sigterm_sigkill_timeout` introduced in #537. I have a very strong hunch that this is tanking CI execution time in our internal repo (after this change, we are only able to complete 17% of relevant tests before timing out, which is blocking my PR to bring in the latest changes from this repo). ## Testing Done N/A Signed-off-by: Katie Hughes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Reverts the calls to
update_sigterm_sigkill_timeoutintroduced in #537. I have a very strong hunch that this is tanking CI execution time in our internal repo (after this change, we are only able to complete 17% of relevant tests before timing out, which is blocking my PR to bring in the latest changes from this repo).Testing Done
N/A