[N/A] better error message if robot is missing joint level api license #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
khughes-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai and
tcappellari-bdai
as code owners
Signed-off-by: Katie Hughes <[email protected]>
khughes-bdai
force-pushed
the
khughes/improve_no_license_error_msg
branch
from
fa48d7c to
4e78560
Compare
jcarpinelli-bdai
approved these changes
Jan 9, 2025
Pull Request Test Coverage Report for Build 12693327648Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
khughes-bdai
added a commit
that referenced
this pull request
Jan 14, 2025
#548) ## Change Overview This came up recently when running the ros2 control stack on a robot that had an expired joint level control license. The error message spammed in this state is just "Failed to get robot state" which is not very helpful. Now this tells the user to double check for the license. ## Testing Done N/A Signed-off-by: Katie Hughes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This came up recently when running the ros2 control stack on a robot that had an expired joint level control license. The error message spammed in this state is just "Failed to get robot state" which is not very helpful. Now this tells the user to double check for the license.
Testing Done
N/A