-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EK-25] Use bosdyn_msgs
bundles
#234
Conversation
FTR CI will fail for now until a new |
@amessing-bdai CI fails for the same reasons it failed over at We can re-work CI here like we did for |
21f79da
to
c72a358
Compare
This now needs bdaiinstitute/spot_wrapper#90. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once the merge conflicts get resolved
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
62cebdb
to
2ab53cf
Compare
Signed-off-by: Michel Hidalgo <[email protected]>
Pull Request Test Coverage Report for Build 8175805734Details
💛 - Coveralls |
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Local testing came out positive (thanks @khughes-bdai!). We are confident enough to move forward with this as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Michel Hidalgo <[email protected]>
Depends on bdaiinstitute/bosdyn_msgs#14. This patch updates this repository to work with the binary bundles that https://github.com/bdaiinstitute/bosdyn_msgs will release from now on. Changes are minimal (but changes nonetheless).
Tested manually by running examples against an Spot robot. I'm open to ideas on how to further test this.