Skip to content

Commit

Permalink
fix: stop installing monocart-coverage-reports
Browse files Browse the repository at this point in the history
Since npm@7 peerDependencies installs deps. Move to the approach used by pixijs
  • Loading branch information
bcoe committed Jun 11, 2024
1 parent 15ac690 commit f0da1f1
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ c8 --experimental-monocart --reporter=v8 --reporter=console-details node foo.js
NOTE: Monocart requires additional `monocart-coverage-reports` to be installed:

```sh
npm i monocart-coverage-reports --save-dev
npm i monocart-coverage-reports@2 --save-dev
```

## Ignoring Uncovered Lines, Functions, and Blocks
Expand Down
2 changes: 1 addition & 1 deletion lib/report.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class Report {
try {
MCR = await this.importMonocart()
} catch (e) {
console.error('--experimental-monocart requires the plugin monocart-coverage-reports. Run: "npm i monocart-coverage-reports --save-dev"')
console.error('--experimental-monocart requires the plugin monocart-coverage-reports. Run: "npm i monocart-coverage-reports@2 --save-dev"')
process.exit(1)
}
return MCR
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
"ts-node": "^10.7.0",
"typescript": "^5.0.0"
},
"peerDependencies": {
"monocart-coverage-reports": "^2.8.3"
"c8Requirements": {
"monocart-coverage-reports": "^2"
},
"engines": {
"node": ">=18"
Expand Down
4 changes: 2 additions & 2 deletions test/integration.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ All files | 100 | 100 | 100 | 100 |
`;
exports[`c8 mergeAsync monocart report check import monocart 1`] = `
",,--experimental-monocart requires the plugin monocart-coverage-reports. Run: \\"npm i monocart-coverage-reports --save-dev\\"
",,--experimental-monocart requires the plugin monocart-coverage-reports. Run: \\"npm i monocart-coverage-reports@2 --save-dev\\"
"
`;
Expand Down Expand Up @@ -1146,7 +1146,7 @@ All files | 100 | 100 | 100 | 100 |
`;
exports[`c8 monocart report check import monocart 1`] = `
",,--experimental-monocart requires the plugin monocart-coverage-reports. Run: \\"npm i monocart-coverage-reports --save-dev\\"
",,--experimental-monocart requires the plugin monocart-coverage-reports. Run: \\"npm i monocart-coverage-reports@2 --save-dev\\"
"
`;
Expand Down

0 comments on commit f0da1f1

Please sign in to comment.