25372 - Support $1.50/$1.00 service fees with $0 base fee in DIRECT_PAY #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jxio
requested review from
seeker25,
ochiu and
rodrigo-barraza
as code owners
seeker25
reviewed
Jan 27, 2025
| line = factory_payment_line_item( | ||
| invoice.id, | ||
| fee_schedule_id=fee_schedule.fee_schedule_id, | ||
| total=base_fee if base_fee is not None else Decimal("10.00"), |
There was a problem hiding this comment.
base_fee or Decimal("10.00") probably would work
|
Taking over this one, Jia is away until Thursday |
|
trying locally |
seeker25
approved these changes
Jan 27, 2025
|
Confirmed working on DEV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#25372
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).