Document Record Service Continuation In Integration #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flutistar
changed the title
seeker25
reviewed
Jan 10, 2025
| const documentClass = 'CORP' | ||
| try { | ||
| const docUrl: string = await BusinessService.getDownloadUrl(documentKey, documentClass) | ||
| const link = document.createElement('a') |
There was a problem hiding this comment.
some Duplicated code, already exists in business.services.ts?
seeker25
reviewed
Jan 10, 2025
|
|
||
| const url = `${ConfigHelper.getLegalAPIV2Url()}/documents/drs/${documentClass}/${documentKey}` | ||
|
|
||
| return axios.get(url).then(response => { |
There was a problem hiding this comment.
.then(), when we're using try catch async await below - seems weird but that's ok - stuff is fairly mix matched right now
seeker25
approved these changes
Jan 10, 2025
|
Question: Is someone taking care of the old documents on MINIO and migrating them over? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#24640
Description of changes:
My name is Brandon Galli from Assets team.
Now we do Document Record Service Continuation In integration as a Proof of Concept.
Technically, Cont In. integration is replacing MinIO with Document Record Service.
getDownloadUrlfunction ondownloadDocumentfunction withgetDownloadUrlfunction onHomeJurisdictionInformation.vue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).