25143 - remove product / add previously approved product support #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochiu
force-pushed
the
25143-remove-product
branch
from
a7f2a1f to
c6ef6e1
Compare
|
ochiu
commented
Jan 8, 2025
| @@ -23,6 +23,7 @@ | |||
| class Error(Enum): | |||
| """Error Codes.""" | |||
|
|
|||
| INVALID_ORG = "The organization ID is in an incorrect format.", HTTPStatus.BAD_REQUEST | |||
There was a problem hiding this comment.
Added this consolidate duplicate code in the org_products route for validating orgId format
ochiu
commented
Jan 8, 2025
| return response, status | ||
|
|
||
|
|
||
| def validate_organization(org_id): |
There was a problem hiding this comment.
mini helper added so routes can re-use it
Jxio
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#25143
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).