Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25138 - Update firm affiliation logic to work in sandbox #3196

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

sameer0422
Copy link
Collaborator

Issue #:
bcgov/entity#25138

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@sameer0422 sameer0422 requested review from seeker25 and argush3 January 6, 2025 21:32
@argush3
Copy link
Collaborator

argush3 commented Jan 6, 2025

looks good. are linting errors and tests being addressed right now?

@sameer0422 sameer0422 self-assigned this Jan 7, 2025
@sameer0422 sameer0422 requested a review from pwei1018 January 7, 2025 16:40
auth-api/poetry.lock Outdated Show resolved Hide resolved
@sameer0422 sameer0422 force-pushed the hotfix/firm-affiliation-sandbox branch 2 times, most recently from a0e9683 to d6381eb Compare January 7, 2025 19:07
@sameer0422 sameer0422 force-pushed the hotfix/firm-affiliation-sandbox branch from b260c9a to 92f04f7 Compare January 7, 2025 19:39
Copy link

sonarqubecloud bot commented Jan 7, 2025

@seeker25 seeker25 merged commit 0470ea7 into bcgov:main Jan 7, 2025
5 of 7 checks passed
@sameer0422 sameer0422 deleted the hotfix/firm-affiliation-sandbox branch January 7, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants