Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21131 - Update product description #3195

Merged
merged 4 commits into from
Jan 7, 2025
Merged

21131 - Update product description #3195

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9239b9d
update product drscription
Jxio Jan 4, 2025
59416ab
version update
Jxio Jan 4, 2025
adedf05
unit tset fix
Jxio Jan 4, 2025
c695fe4
typo
Jxio Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions auth-web/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion auth-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "auth-web",
"version": "2.7.0",
"version": "2.7.1",
"appName": "Auth Web",
"sbcName": "SBC Common Components",
"private": true,
Expand Down
7 changes: 6 additions & 1 deletion auth-web/src/components/auth/common/Product.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
class="title font-weight-bold product-title mt-n1"
:data-test="productDetails.code"
>
{{ productDetails.description }}
{{ productDiscription(productDetails.code, productDetails.description) }}
<v-tooltip
v-if="productPremTooltipText(productDetails.code)"
class="pa-2"
Expand Down Expand Up @@ -199,6 +199,7 @@ import AccountMixin from '@/components/auth/mixins/AccountMixin.vue'
import LaunchDarklyService from 'sbc-common-components/src/services/launchdarkly.services'
import ProductFee from '@/components/auth/common/ProductFeeViewEdit.vue'
import ProductTos from '@/components/auth/common/ProductTOS.vue'
import { productDisplay } from '@/resources/display-mappers'

const TOS_NEEDED_PRODUCT = ['VS']

Expand Down Expand Up @@ -379,6 +380,10 @@ export default class Product extends Mixins(AccountMixin) {
public productPremTooltipText (code: string) {
return LaunchDarklyService.getFlag(`product-${code}-prem-tooltip`)
}

public productDiscription (code: string, description: string) {
seeker25 marked this conversation as resolved.
Show resolved Hide resolved
return productDisplay[code] || description
}
}
</script>

Expand Down
4 changes: 2 additions & 2 deletions auth-web/tests/unit/components/Product.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ describe('Product.vue', () => {

const productDetails = {
'code': 'VS',
'description': 'test',
'description': 'Vital Statistics',
'url': 'url',
'type': 'PARTNER',
'subscriptionStatus': ProductStatus.NOT_SUBSCRIBED
}
const pprProduct = {
'code': 'PPR',
'description': 'ppr',
'description': 'Personal Property Registry',
'url': 'url',
'type': 'PARTNER',
'subscriptionStatus': ProductStatus.NOT_SUBSCRIBED,
Expand Down
Loading