21429 - staff account search for members #3169
Conversation
| AND memberships.status = 1 | ||
| AND users.status = 1 | ||
| AND CONCAT(users.last_name, ' ', users.first_name, ' ', users.username) ILIKE :member_search_text | ||
| ) |
There was a problem hiding this comment.
Needed to use string subquery due to model cyclic dependencies.
Membership model has an org import.
There was a problem hiding this comment.
Haha, this should be refactored to a service preferably and done in ORM.
I see it uses contacts and contact links which have nothing to do with orgs (in the model :( , not your changes .. )
The only spot it's called is from the service too. Service already is 1000 lines, looks crowded too.
If this was pay, would definitely have to refactor.
There was a problem hiding this comment.
As long as there is a unit test should be ok (if the datamodel changes etc), but I'll leave it up to you to decide
There was a problem hiding this comment.
I think we should make a ticket for the sbc-connect team to break alot of these dependencies as well?
There was a problem hiding this comment.
Yes, I started looking at doing a refactor, and it became a larger undertaking then I wanted for the scope of this ticket. Since it was just a subquery I kept it simple.
I agree we should probably have some kind of tech debt ticket to clean this up.
|
Issue #:
bcgov/entity#21429
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).