21560 - EFT Payment reminder template updates #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seeker25
reviewed
Sep 3, 2024
| {% if short_name_links_count > 1 %} | ||
| There's an amount owing on your account for your {{ statement_month }} statement (#{{ statement_number }}), which is due today {{ due_date }}. | ||
| {% else %} | ||
| There's an amount owing of {{ total_amount_owing }} on your account for your {{ statement_month }} statement (#{{ statement_number }}), which is due today {{ due_date }}. |
There was a problem hiding this comment.
Isn't it possible to combine these a bit more?
There was a problem hiding this comment.
GPT:
{% set owing_message = "There's an amount owing" %}
{% set amount_details = '' if short_name_links_count > 1 else ' of {{ total_amount_owing }}' %}
{{ owing_message }}{{ amount_details }} on your account for your {{ statement_month }} statement (#{{ statement_number }}), which is due today {{ due_date }}.
There was a problem hiding this comment.
Possibly, I prefer the whole sentence rather trying to combine fragments though when we have to modify it.
There was a problem hiding this comment.
ok, then you'll be modifying it twice if the base sentence needs to change
seeker25
reviewed
Sep 3, 2024
|
|
||
| ## {{ account_number }}: {{ account_name_with_branch }} | ||
| {% if short_name_links_count > 1 %} |
seeker25
approved these changes
Sep 3, 2024
pwei1018
pushed a commit
to pwei1018/sbc-auth
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#21560
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).