21813 Added Continuation Authorization Review page, route, etc #2894

severinbeauvais · 2024-07-04T21:42:21Z

Description of changes:

app version = 2.6.41
imported shared jurisdictions
imported lodash isDate + type
added CSS variable $px-15
added CardHeader.vue
added ExtraprovincialRegistrationBc.vue
added HomeJurisdictionInformation.vue
added continuation review interfaces
added route
added fetchContinuationReview() (with mocked data)
added downloadDocument()
added DateUtils class
added ContinuationAuthorizationReview.vue
unit test are WIP

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

ArwenQin

Looks good.

severinbeauvais · 2024-07-04T23:31:54Z

auth-web/src/components/auth/common/CardHeader.vue

This is copied right from Create UI.

severinbeauvais · 2024-07-04T23:32:54Z

auth-web/src/components/auth/staff/continuation-in/ExtraprovincialRegistrationBc.vue

@@ -0,0 +1,126 @@
+<template>
+  <div
+    v-if="!!continuationIn"


Don't render this component until/unless we have data.

I should be able to remove some of the conditional chaining (a?.b) with this.

I've decided to keep the conditional chaining in place, so that the computeds don't depend on the template. (Ie, the computeds are only evaluated when referenced in the template, and the template won't render without the main object.)

severinbeauvais · 2024-07-04T23:33:09Z

auth-web/src/components/auth/staff/continuation-in/HomeJurisdictionInformation.vue

@@ -0,0 +1,387 @@
+<template>
+  <div
+    v-if="!!continuationIn"


Don't render this component until/unless we have data.

severinbeauvais · 2024-07-04T23:33:50Z

auth-web/src/components/auth/staff/continuation-in/HomeJurisdictionInformation.vue

+    return (
+      entityType === CorpTypes.ULC_CONTINUE_IN &&
+      country === 'CA' &&
+      (region === 'AB' || region === 'NS')


We don't have constants for countries or regions and I think that's overkill for here.

severinbeauvais · 2024-07-04T23:34:31Z

auth-web/src/routes/router.ts

+      path: '/staff/continuation-review/:reviewId',
+      name: 'ContinuationReview',
+      component: ContinuationAuthorizationReview,
+      props: true,


This passes the variable in the path (reviewId) into the component as a prop.

- imported shared jurisdictions - imported lodash isDate + type - added CSS variable $px-15 - added CardHeader.vue - added ExtraprovincialRegistrationBc.vue - added HomeJurisdictionInformation.vue - added continuation review interfaces - added route - added fetchContinuationReview() (with mocked data) - added downloadDocument() - added DateUtils class - added ContinuationAuthorizationReview.vue - updated browserslist - added unit tests

severinbeauvais · 2024-07-05T17:26:46Z

auth-web/tests/unit/components/ContinuationAuthorizationReview.spec.ts

✓ tests/unit/components/ContinuationAuthorizationReview.spec.ts (8) ✓ ExtraprovincialRegistrationBc component (8) ✓ got the prop ✓ fetched the continuation review object ✓ computed "isExpro" ✓ rendered the component ✓ rendered the error dialog ✓ rendered the container header ✓ rendered the first v-card ✓ rendered the second v-card Test Files 1 passed (1) Tests 8 passed (8) Start at 10:26:25 Duration 2.32s (transform 1.15s, setup 824ms, collect 665ms, tests 110ms, environment 236ms, prepare 144ms)

severinbeauvais · 2024-07-05T17:27:26Z

auth-web/tests/unit/components/ExtraprovincialRegistrationBc.spec.ts

✓ tests/unit/components/ExtraprovincialRegistrationBc.spec.ts (6) ✓ ExtraprovincialRegistrationBc component (6) ✓ got the prop ✓ rendered the component ✓ rendered all the articles ✓ rendered the first article ✓ rendered the second article ✓ rendered the third articles Test Files 1 passed (1) Tests 6 passed (6) Start at 10:27:04 Duration 2.01s (transform 985ms, setup 827ms, collect 464ms, tests 63ms, environment 221ms, prepare 156ms)

severinbeauvais · 2024-07-05T17:28:08Z

auth-web/tests/unit/components/HomeJurisdictionInformation.spec.ts

✓ tests/unit/components/HomeJurisdictionInformation.spec.ts (14) ✓ HomeJurisdictionInformation component (14) ✓ got the prop ✓ computed "isContinuationInAffidavitRequired" ✓ rendered the component ✓ rendered the error dialog ✓ rendered all the articles ✓ rendered the first article ✓ rendered the second article ✓ rendered the third article ✓ rendered the fourth article ✓ rendered the fifth article ✓ rendered the sixth article ✓ rendered the seventh article ✓ rendered a functional affidavit download button ✓ rendered a functional authorization download button Test Files 1 passed (1) Tests 14 passed (14) Start at 10:27:33 Duration 2.26s (transform 1.05s, setup 845ms, collect 568ms, tests 154ms, environment 235ms, prepare 95ms)

severinbeauvais · 2024-07-05T17:33:56Z

/gcbrun

seeker25 · 2024-07-05T17:36:01Z

auth-web/src/util/date-utils.ts

+    // 2. compute the offset between UTC and Pacific timezone
+    // 3. add the offset to convert the date to Pacific timezone
+    // Ref: https://stackoverflow.com/questions/15141762/
+    const date = new Date(Date.UTC(year, month, day, hours, minutes))


Use moment/or library, no point in reinventing the wheel

Moment is pretty heavy (though it's already imported in this UI).

This is code from our "legacy" date library. JS is enough. Don't need moment 😛

Don't need your JS library, there are professionals that do this for a living

there are plenty of other ones

Moment was great when JS didn't handle dates well.

seeker25 · 2024-07-05T17:36:12Z

auth-web/src/views/auth/staff/ContinuationAuthorizationReview.vue

+
+  get isExpro (): boolean {
+    const mode = this.continuationReview?.filing?.continuationIn?.mode
+    return (mode === 'EXPRO')


I didn't bother for 2 possible values. Here's the IF:

seeker25 · 2024-07-05T17:37:28Z

auth-web/src/services/business.services.ts

+      // use Navigator.msSaveOrOpenBlob if available (possibly IE)
+      // warning: this is now deprecated
+      // ref: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/msSaveOrOpenBlob
+      if (window.navigator && window.navigator['msSaveOrOpenBlob']) {


We don't support IE 11?

I copied this from our other UIs.

I see that common-utils.ts has slightly different blob handling. Do you recommend I update the code above?

sbc-auth/auth-web/src/util/common-util.ts

Line 156 in e242563

static fileDownload (data: any, fileName: string, fileType: string = 'text/plain') {

JazzarKarim · 2024-07-05T17:39:21Z

auth-web/src/components/auth/common/CardHeader.vue

@@ -0,0 +1,43 @@
+<template>


I've already added this component with unit tests and everything a while back with unit tests and everything:
https://github.com/bcgov/sbc-auth/blob/main/auth-web/src/components/CardHeader.vue

Keep in mind that my version has extra functionalities/props like a badge.

Thanks. Dunno how I didn't see it.

I'll update this in the follow-on next ticket (bcgov/entity#21815).

No problem! Also, I changed the version here to use composition API to stay consistent in AUTH WEB as per a conversation I had with Travis.

Yup.
I believe we're going to have a chat on Monday about moving some stuff out of Auth Web and into a new UI project. That new UI will probably be Nuxt. When we port code over, it can be converted to Composition API.

bcregistry-sre · 2024-07-05T17:54:19Z

Temporary Url for review: https://bcregistry-account-dev--pr-2894-vwhzlljl.web.app

SB says, try this: https://bcregistry-account-dev--pr-2894-vwhzlljl.web.app/staff/continuation-review/1234

severinbeauvais requested review from Jxio, seeker25, ochiu and rodrigo-barraza as code owners July 4, 2024 21:42

severinbeauvais self-assigned this Jul 4, 2024

severinbeauvais requested a review from ArwenQin July 4, 2024 21:45

ArwenQin approved these changes Jul 4, 2024

View reviewed changes

severinbeauvais commented Jul 4, 2024

View reviewed changes

auth-web/src/components/auth/common/CardHeader.vue Outdated

Copy link

Collaborator Author

severinbeauvais Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied right from Create UI.

severinbeauvais commented Jul 4, 2024

View reviewed changes

bcgov deleted a comment from bcregistry-sre Jul 4, 2024

severinbeauvais force-pushed the 21813 branch from 78666ad to 5356a03 Compare July 5, 2024 17:24

severinbeauvais force-pushed the 21813 branch from 5356a03 to fbe09bb Compare July 5, 2024 17:24

severinbeauvais requested a review from JazzarKarim July 5, 2024 17:25

severinbeauvais commented Jul 5, 2024

View reviewed changes

seeker25 reviewed Jul 5, 2024

View reviewed changes

seeker25 approved these changes Jul 5, 2024

View reviewed changes

seeker25 merged commit e242563 into bcgov:main Jul 5, 2024
3 of 4 checks passed

JazzarKarim reviewed Jul 5, 2024

View reviewed changes

bcgov deleted a comment from bcregistry-sre Jul 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

21813 Added Continuation Authorization Review page, route, etc #2894

21813 Added Continuation Authorization Review page, route, etc #2894

severinbeauvais commented Jul 4, 2024

ArwenQin left a comment

severinbeauvais Jul 4, 2024

severinbeauvais Jul 4, 2024

severinbeauvais Jul 5, 2024

severinbeauvais Jul 4, 2024

severinbeauvais Jul 4, 2024

severinbeauvais Jul 4, 2024

severinbeauvais Jul 5, 2024

severinbeauvais Jul 5, 2024

severinbeauvais Jul 5, 2024

severinbeauvais commented Jul 5, 2024

seeker25 Jul 5, 2024

severinbeauvais Jul 5, 2024

seeker25 Jul 5, 2024

severinbeauvais Jul 5, 2024

seeker25 Jul 5, 2024

severinbeauvais Jul 5, 2024

seeker25 Jul 5, 2024

severinbeauvais Jul 5, 2024 •

edited

Loading

JazzarKarim Jul 5, 2024

severinbeauvais Jul 5, 2024

JazzarKarim Jul 5, 2024

severinbeauvais Jul 5, 2024

bcregistry-sre commented Jul 5, 2024 •

edited by severinbeauvais

Loading

21813 Added Continuation Authorization Review page, route, etc #2894

21813 Added Continuation Authorization Review page, route, etc #2894

Conversation

severinbeauvais commented Jul 4, 2024

ArwenQin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais commented Jul 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais Jul 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcregistry-sre commented Jul 5, 2024 • edited by severinbeauvais Loading

severinbeauvais Jul 5, 2024 •

edited

Loading

bcregistry-sre commented Jul 5, 2024 •

edited by severinbeauvais

Loading