20907 - EFT Pay outstanding balance #2872
Conversation
|
|
| const isFromEFT = props.currentOrgPaymentType === PaymentTypes.EFT | ||
| if (!hasOutstandingBalance) { | ||
| bcOnlineDialog.value.close() | ||
| } else if (hasOutstandingBalance && isFromEFT) { |
There was a problem hiding this comment.
} else if (hasOutstandingBalance && isFromEFT) { -> } else if (isFromEFT) {
| @@ -1,3 +1,5 @@ | |||
| @import 'theme.scss'; | |||
There was a problem hiding this comment.
I noticed some parts you imported Theme as well as actions below
Maybe only need actions.scss with this line?
There was a problem hiding this comment.
removed, don't actually need this import
| align-items: center; | ||
| } | ||
| .payment-type-label { | ||
| display: flex; |
There was a problem hiding this comment.
there are Vuetify classes for these
There was a problem hiding this comment.
| margin-bottom: 12px !important; | ||
|
|
||
| .payment-method-card-text { | ||
| display: flex; |
There was a problem hiding this comment.
there are Vuetify classes for these
There was a problem hiding this comment.
| } | ||
| } | ||
| .payment-method-description{ | ||
| display: flex; |
There was a problem hiding this comment.
there are Vuetify classes for these
There was a problem hiding this comment.
| @@ -831,6 +831,11 @@ export const useOrgStore = defineStore('org', () => { | |||
| setCurrentOrganizationPADInfo(undefined) | |||
| } | |||
|
|
|||
| async function createOutstandingAccountPayment () { | |||
| const response = await PaymentService.createOutstandingAccountPayment(state.currentOrganization.id) | |||
There was a problem hiding this comment.
This should be moved to the service? do we care about response.data? in the store?
probably not..
There was a problem hiding this comment.
This doesn't do it with async, but I think we should make our services a bit more complicated (which should simplify stores):
There was a problem hiding this comment.
Makes sense, this would help the component logic to be more clean and less repetitive. I will be in this code soon doing EFT --> PAD screens probably. I will try to move the EFT calls out to the service when I do that.
|
Code quality issue on the unit test? I've seen this one before.. lol can't remember if the suggestion fixes it |
# Conflicts: # auth-web/package-lock.json # auth-web/package.json
|
|
Will merge after PR #1573 is in |
Issue #:
bcgov/entity#20907
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).