Add in some small tweaks #2721
Merged
Add in some small tweaks #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
requested review from
Jxio,
ochiu and
rodrigo-barraza
as code owners
|
seeker25
commented
Feb 9, 2024
| @@ -169,7 +169,7 @@ export default defineComponent({ | |||
| root.$router?.push({ | |||
| name: 'shortnamedetails', | |||
| params: { | |||
| 'shortNameId': state.results[index].id | |||
| 'shortNameId': state.results[index].id?.toString() | |||
There was a problem hiding this comment.
it was complaining about a number being passed not a string
seeker25
commented
Feb 9, 2024
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <v-card> | |||
| <v-card v-if="shortNameDetails.shortName"> | |||
There was a problem hiding this comment.
This should make the bottom more consistent
ochiu
approved these changes
Feb 9, 2024
seeker25
commented
Feb 9, 2024
| @@ -81,7 +81,7 @@ export default defineComponent({ | |||
|
|
|||
| const state = reactive<EFTTransactionState>({ | |||
| results: [], | |||
| totalResults: 1, | |||
| totalResults: 0, | |||
There was a problem hiding this comment.
Was showing 1, then going to 0, maybe this is better at 1 actually lol
seeker25
commented
Feb 9, 2024
| @@ -91,7 +91,7 @@ export default defineComponent({ | |||
| }) | |||
|
|
|||
| const paymentsReceived = computed<string>(() => { | |||
| return `Payments Received from ${props.shortNameDetails.shortName}` | |||
| return props.shortNameDetails.shortName ? `Payments Received from ${props.shortNameDetails.shortName}` : 'Loading...' | |||
There was a problem hiding this comment.
Small loading text, otherwise it has undefined for shortName - really hard to see though
seeker25
commented
Feb 9, 2024
| @@ -1,7 +1,7 @@ | |||
| <template> | |||
| <v-container | |||
| id="dashboard" | |||
| class="container mt-4" | |||
| id="short-name-mapping-view" | |||
There was a problem hiding this comment.
id rename, spacing so it's consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).