-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
19332 - Short name account link modal #2720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
/gcbrun |
Temporary Url for review: https://bcregistry-account-dev--pr-2720-mgg2g9o6.web.app |
Modal size needs to be increased, should be 720x, I think it's 620 ish |
Close -> Cancel it should be outlined in style |
Also think you need to handle |
/gcbrun |
Temporary Url for review: https://bcregistry-account-dev--pr-2720-mgg2g9o6.web.app |
/gcbrun |
Temporary Url for review: https://bcregistry-account-dev--pr-2720-mgg2g9o6.web.app |
/gcbrun |
Temporary Url for review: https://bcregistry-account-dev--pr-2720-mgg2g9o6.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update package + package-lock.json again please?
Quality Gate failedFailed conditions |
Issue #:
https://github.com/bcgov/entity/issues/
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).