17588 - Upgrade to Node 20.5.1 && Fix FAS-UI Library #2710
Conversation
seeker25
requested review from
Jxio,
ochiu and
rodrigo-barraza
as code owners
| @@ -25,7 +25,7 @@ | |||
| "@vue/compiler-dom": "^3.2.45", | |||
| "@vue/composition-api": "^1.7.1", | |||
| "axios": "^1.6.0", | |||
| "fas-ui": "github:bcgov/fas-ui#v1.1.4", | |||
There was a problem hiding this comment.
Old version was causing a npm error that could only be replicated in CI and Dockerfile
New library version required a bit of going in and testing and debugging to get it to work with Vite and Terser etc. (Why I upped the points)
| @@ -66,7 +66,7 @@ export default defineConfig({ | |||
| // Fix for module decorator unit tests fail | |||
| 'vuex-module-decorators': path.resolve(__dirname, './node_modules/vuex-module-decorators/dist/esm/index.js'), | |||
| // Fix for multiple vue detected on fas-ui issue, set alias to force fas-ui to use /vue | |||
| 'vue': path.resolve(__dirname, './node_modules/vue/dist/vue.runtime.esm.js') | |||
There was a problem hiding this comment.
FAS Component didn't use ESM, reverting back to the regular seemed to fix it, otherwise the Vue references inside of FAS-UI required Vue.default. instead of Vue. to work correctly
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2710-xrwhxk8f.web.app |
| @@ -29,6 +29,10 @@ export default defineConfig({ | |||
| define: { | |||
| 'import.meta.env.ABOUT_TEXT': generateAboutText(aboutText1, aboutText2) | |||
| }, | |||
| esbuild: { | |||
| minifySyntax: false, | |||
There was a problem hiding this comment.
ERROR [Vue warn]: Invalid component name: "ContractForm$1". To fix these
seeker25
changed the title
|
Going to do a release before merging this |
|
bcgov/entity#17588
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).