Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16904 - Add EFT Payment Option #2617

Merged
merged 4 commits into from
Oct 30, 2023
Merged

16904 - Add EFT Payment Option #2617

merged 4 commits into from
Oct 30, 2023

Conversation

Jxio
Copy link
Collaborator

@Jxio Jxio commented Oct 20, 2023

Issue #:
bcgov/entity#16904

Description of changes:

  1. Add EFT Payment Option to Payment methods
  2. Add enable_eft flag to store
  3. convert PaymentMethod.vue to composition-api

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@Jxio Jxio self-assigned this Oct 20, 2023
computed: {
...mapState(useOrgStore, [
'currentOrgPaymentDetails'
])
}
})
export default class PaymentMethods extends Vue {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably convert this component into composition-api

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small point of converting it into composition-api

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bcgov bcgov deleted a comment from bcregistry-sre Oct 30, 2023
@Jxio
Copy link
Collaborator Author

Jxio commented Oct 30, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2617-lsa9cply.web.app

@Jxio Jxio merged commit 9864cca into bcgov:main Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants