Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SE reg type amendment set up. #1979

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix SE reg type amendment set up. #1979

merged 1 commit into from
Jul 15, 2024

Conversation

doug-lovett
Copy link
Collaborator

Issue #: /bcgov/entity#22195

Description of changes:

  • SE current view of base registration remove amendNoticeId from notices, amendOrderId from orders.
  • Verification report set up handle case where all orders are deleted from an amended notice.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@doug-lovett doug-lovett self-assigned this Jul 15, 2024
cameron-eyds
cameron-eyds approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@doug-lovett doug-lovett merged commit 5d62285 into bcgov:main Jul 15, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameron-eyds cameron-eyds cameron-eyds approved these changes

@flutistar flutistar Awaiting requested review from flutistar

Assignees

@doug-lovett doug-lovett

Labels
PPR API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doug-lovett @cameron-eyds