Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PPR party client code formatting and matching. #1706

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Update PPR party client code formatting and matching. #1706

merged 1 commit into from
Jan 27, 2024

Conversation

doug-lovett
Copy link
Collaborator

Issue #: /bcgov/entity#19436

Description of changes:

  • Format client party codes with leading zeroes. Currently 0115 returns no results when 3 codes exist with a head office code of 115.
  • The first 4 digits will always match on the head office code. Currently 001 and 0001 match on 00000001. 001 will match on head office codes 1 and 10 to 19. 0001 will match on head office code 1.
  • When matching on more than 4 digits, match on the formatted values with leading zeroes.
  • Sort by party code when multiple results exist.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Signed-off-by: Doug Lovett <[email protected]>
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@doug-lovett doug-lovett merged commit cd6cdd8 into bcgov:main Jan 27, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants