Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transport Permit validations #1701

Merged
merged 21 commits into from
Jan 26, 2024
Merged

Transport Permit validations #1701

merged 21 commits into from
Jan 26, 2024

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Jan 23, 2024

Issue #:

Description of changes:

  • Validations for Transport Permit fields
  • Unit tests
  • Refactoring

Screenshots

Screenshot 2024-01-22 at 19 03 37

Screenshot 2024-01-22 at 19 03 59

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 added the MHR Transport Permit Transport Permit Registration label Jan 23, 2024
@dimak1 dimak1 self-assigned this Jan 23, 2024
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 23, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1701-vxe8fau5.web.app

doug-lovett
doug-lovett approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

cameron-eyds
cameron-eyds approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor comment!

Please do not merge until after demo however 👍
I'll put a tag on until we're done

@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 23, 2024 •
edited
Loading

Looks good to me, just a minor comment!

Please do not merge until after demo however 👍 I'll put a tag on until we're done

Thanks for review, @cameron-eyds no I wasn't planning to merge, especially before demo. We still need some UXA feedback...

@cameron-eyds
Copy link
Collaborator

Looks good to me, just a minor comment!
Please do not merge until after demo however 👍 I'll put a tag on until we're done

Thanks for review, @cameron-eyds no I wasn't planning to merge, especially before demo. We still need some UXA feedback...

Sounds good, whenever your ready now!

@dimak1 dimak1 force-pushed the feat/transport-permit-validations branch from f7d74da to a5b41fd Compare January 23, 2024 20:03
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 23, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1701-vxe8fau5.web.app

@dimak1 dimak1 force-pushed the feat/transport-permit-validations branch from d88c32c to 2091108 Compare January 25, 2024 22:21
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 25, 2024

/gcbrun

1 similar comment
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 25, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1701-vxe8fau5.web.app

1 similar comment
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1701-vxe8fau5.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 26, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1701-vxe8fau5.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 26, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1701-vxe8fau5.web.app

@dimak1 dimak1 force-pushed the feat/transport-permit-validations branch from ef33719 to 34f4206 Compare January 26, 2024 23:27
@dimak1 dimak1 merged commit 9b66801 into bcgov:main Jan 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameron-eyds cameron-eyds cameron-eyds approved these changes

@doug-lovett doug-lovett doug-lovett approved these changes

Assignees

@dimak1 dimak1

Labels
MHR Transport Permit Transport Permit Registration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimak1 @bcregistry-sre @cameron-eyds @doug-lovett