Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General MHR Items + Misc PPR QA items #1661

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#18936 /bcgov/entity#19010 /bcgov/entity#18913 /bcgov/entity#18919 /bcgov/entity#18916

Description of changes:

  • General MHR items which include updated validations and some home owners functional bugs
  • General app scroll to effects built into nav helper
  • PPR styling class updates to restore red text and error borders
  • Contact expansion bug fix - display content in slot
  • Added two util functions (one to filter duplicates in lists, another a scroll to top helper)
  • Minor test updates
  • Default route to Dashboard to help staff whom are already authenticated entering the application from being redirect back to auth
  • Load MHR table data after MH Reg filings, previously was not displaying recently filed filings (bug exists in test)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Dec 15, 2023
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1661-fu5f6981.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding. Mr. Clean ............. Up

@cameron-eyds
Copy link
Collaborator Author

Outstanding. Mr. Clean ............. Up

hahah
I'll be looking like Mr Clean by the time this upgrade is complete :)

@seeker25
Copy link

I already look like Mr Clean

@cameron-eyds cameron-eyds merged commit dbcb95a into bcgov:main Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants