-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputField DatePicker: Update min/max defaults #1650
Conversation
/gcbrun |
nudgeTop: { type: String, default: null }, | ||
nudgeBottom: { type: String, default: null }, | ||
nudgeRight: { type: String, default: null }, | ||
nudgeLeft: { type: String, default: null }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'nudges' are no longer a part of vuetify, they use offset objects of which we are not really using anymore.
Removing these until they are used/required.
Temporary Url for review: https://bcregistry-assets-dev--pr-1650-evmfo4tu.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Issue #: /bcgov/entity#16986
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).