Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputField DatePicker: Update min/max defaults #1650

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#16986

Description of changes:

  • Don't set date defaults when no min or max props dates are passed. (ie no range restriction)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Dec 8, 2023
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

Comment on lines -89 to -92
nudgeTop: { type: String, default: null },
nudgeBottom: { type: String, default: null },
nudgeRight: { type: String, default: null },
nudgeLeft: { type: String, default: null },
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'nudges' are no longer a part of vuetify, they use offset objects of which we are not really using anymore.
Removing these until they are used/required.

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1650-evmfo4tu.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RuoxuanPengBC RuoxuanPengBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cameron-eyds cameron-eyds merged commit 6e3939c into bcgov:main Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants