Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Land Lease validation for draft MHR Registrations #1647

Closed
wants to merge 2 commits into from

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Dec 6, 2023

Description of changes:

  • Fix Land Lease validation for draft MHR Registrations

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #1647 (d38a453) into main (9255e77) will increase coverage by 4.90%.
Report is 337 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
+ Coverage   72.35%   77.25%   +4.90%     
==========================================
  Files         307      381      +74     
  Lines       12767     7061    -5706     
  Branches     2630     1132    -1498     
==========================================
- Hits         9237     5455    -3782     
+ Misses       3518     1574    -1944     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.25% <ø> (+4.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 33 more

... and 284 files with indirect coverage changes

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great,
After you merge, we will promote straight to TEST, so we can get our feature back to Dev 👍
Just keep me posted!

@dimak1
Copy link
Collaborator Author

dimak1 commented Dec 6, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1647-zjvclufs.web.app

Copy link
Contributor

@RuoxuanPengBC RuoxuanPengBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@cameron-eyds
Copy link
Collaborator

Closing as a fix was applied in PR: #1659 and released as a hotfix.
Have also committed the fix to our main branch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants