-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Land Lease validation for draft MHR Registrations #1647
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
+ Coverage 72.35% 77.25% +4.90%
==========================================
Files 307 381 +74
Lines 12767 7061 -5706
Branches 2630 1132 -1498
==========================================
- Hits 9237 5455 -3782
+ Misses 3518 1574 -1944
- Partials 12 32 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great,
After you merge, we will promote straight to TEST, so we can get our feature back to Dev 👍
Just keep me posted!
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1647-zjvclufs.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Closing as a fix was applied in PR: #1659 and released as a hotfix. |
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).