Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 - Feature Branch Fold In #1642

Merged
merged 15 commits into from
Dec 8, 2023
Merged

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#16983

Description of changes:

  • Pr for folding in feature branch back into our main branch

Includes

  • Vue 3 upgrade
  • Vuetify upgrade
  • Vite migration
  • Vitest migration
  • Removal of many previously use technologies, such as Jest, webpack and many unsupported component packages

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

cameron-eyds and others added 10 commits December 4, 2023 10:46
* Vue3 Build (#1594)

* Vue3/Vuetify3/Vite-Build

* wip: Up to Searches

* wip: Search Features

* Wip: PPR Search Done - Onto Mhr Search Results

* Refactors generally completed on PPR/MHR Searches and history

* CI Updates

* update dockerfil

* revert docker file udpates

* docker change reverse

* Docker update

* docker node version update

* last attempt at ci build

* vue-affix removal

* Lint Fixes

* lint config updates

* Modernized Linting for Vue and Typescript -- Applied non functional fixes

* Updated vue declaration

* Vuetify and component updates - PRR (#1609)

* base dialog and Staff Payment instances updated

* ongoing PPR Table work

* Ongoin PPR Registrations/Amendment updates

* Ongoing PPR Reg - Includes stepper, footers, Bus Search, Base Address

* Ppr Registrations Happy Path

* Chips and other misc fixes for Amendments

* Vuetify Fixes for MHR and Misc Features (#1615)

* Mhr Registrations Happy Path

* Ongoing Registration Table Improvements

* User access Start, some more table clean up

* User Access Fixes + more table updates

* Cleaned up Tables Sorting

* Further Transfer and Unit Note Adjustments

* Masking fixes and replacements

* Date Pickers and misc styling adjustments

* Lint Sweeps and camelCase enforcement

* Reg Table Fix and command revert

* Further DatePicker Updates

* ViTest: Unit Testing Setup/Config/Utils and Ongoing Refactoring (#1623)

* Ongoing Unit Test fixes

* Ongoing PPR Test fixes - Includes base setup - solves most complexity - now test fixes

* more test config updates and unit test fixes

* button-footer rework

* Further Testing updates - Up to Debtors

* continued testing updates DischargeReg

* Tests up to EditTrust and more cleanup

* PR CleanUP

* Few more tests - up to FeeSummary

* FeeSummary test

* Lint update

* fee summary file clean up

* Sync Clean Up

* Ongoing test work

* Delete .idea directory
* Ongoing tests: nearly complete

* Only Table row and reg wrapper to complete

* setup adjustments

* Reg Wrapper and Fetching updates

* ppr testing finalized

* jest clean up and terminal clean up
* ongoing Linting

* Lint Fixes

* no gutters update

* MakeModel Test Fix
* Test Updates, Misc UI fixes

* ts config clean up
* Further updated to unit tests

* More unit test updates

* Further unit test updates

* More unit test updates

* Fix errors in Dashboard test by mocking api calls

* Fix Signout test from error

* Fix some of Typescript errors
* Misc Ui clean up

* remove dev code

* remove more dev code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Delay app mount to allow for auth data

* spacing fix

* optional chain doc for testing env

* linting fixes

* test fix and spelling correction

* Console cleanup
@cameron-eyds cameron-eyds self-assigned this Dec 5, 2023
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1642-gnlazust.web.app

@dimak1 dimak1 added the Vue3 Migration Work related to Vue3 migration. label Dec 5, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Fix Lien Alert message for QS

* Version update

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Authentication Flow updates

* minor syntax fix and error handling

* Remove extra console

* RL Collateral Selector fix
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1642-gnlazust.web.app

cameron-eyds and others added 3 commits December 6, 2023 11:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* sbc-cc updates (for axios V) and axios interceptor updates

* Version bump

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Home Owners Styling and Bug fixes

* Pr Updates
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1642-gnlazust.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what an amazing amount of work. I skipped the unit tests and scanned most of the rest. Fantastic work.

@cameron-eyds
Copy link
Collaborator Author

Wow, what an amazing amount of work. I skipped the unit tests and scanned most of the rest. Fantastic work.

Thank you! It was for sure, a huge collaboration between a lot of folks. Our team and others.
Still some fine tuning to go but getting closer everyday.

@cameron-eyds cameron-eyds merged commit d62125e into main Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vue3 Migration Work related to Vue3 migration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants