-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update unit note expired status #1634
Fix/update unit note expired status #1634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment, and also please update the version.
Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app |
Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
+ Coverage 72.35% 77.24% +4.89%
==========================================
Files 307 381 +74
Lines 12767 7062 -5705
Branches 2630 1133 -1497
==========================================
- Hits 9237 5455 -3782
+ Misses 3518 1575 -1943
- Partials 12 32 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app |
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks complicated!
Looks good to me though 👍
Issue #: /bcgov/entity#18071
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).