Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update unit note expired status #1634

Merged

Conversation

RuoxuanPengBC
Copy link
Contributor

@RuoxuanPengBC RuoxuanPengBC commented Nov 27, 2023

Issue #: /bcgov/entity#18071

Description of changes:

  1. Updated the expired status in MHR table column - 'days to expire'
  2. updated expired continued NoC in unit note header info from NoC(continued) to NoC(expired)
  3. updated expired extended NoC in unit note header info from NoC(extended) to NoC(expired)
  4. minor bug fixed for Issue #: /UI - Update Land Lease or Own component to a yes or no question that's required entity#18017

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment, and also please update the version.

ppr-ui/src/composables/mhrInformation/useMhrUnitNote.ts Outdated Show resolved Hide resolved
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #1634 (991b2fd) into main (9255e77) will increase coverage by 4.89%.
Report is 333 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
+ Coverage   72.35%   77.24%   +4.89%     
==========================================
  Files         307      381      +74     
  Lines       12767     7062    -5705     
  Branches     2630     1133    -1497     
==========================================
- Hits         9237     5455    -3782     
+ Misses       3518     1575    -1943     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.24% <ø> (+4.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 34 more

... and 283 files with indirect coverage changes

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app

@RuoxuanPengBC
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updates.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks complicated!
Looks good to me though 👍

@cameron-eyds cameron-eyds merged commit b3b69e8 into bcgov:main Dec 4, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants