Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

residential exemption staff text updates #1614

Merged

Conversation

RuoxuanPengBC
Copy link
Contributor

Issue #: /bcgov/entity#18307

Description of changes:

updated the stuff text of residential exemption

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@RuoxuanPengBC
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1614-fraqswqe.web.app

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1614 (8d17165) into main (9255e77) will increase coverage by 4.97%.
Report is 319 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
+ Coverage   72.35%   77.32%   +4.97%     
==========================================
  Files         307      379      +72     
  Lines       12767     7016    -5751     
  Branches     2630     1121    -1509     
==========================================
- Hits         9237     5425    -3812     
+ Misses       3518     1559    -1959     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.32% <ø> (+4.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 34 more

... and 281 files with indirect coverage changes

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@RuoxuanPengBC RuoxuanPengBC force-pushed the fix/update-residential-exemption-staff-text branch from 6f1df48 to 8d17165 Compare November 6, 2023 21:05
@RuoxuanPengBC
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1614-fraqswqe.web.app

@dimak1 dimak1 merged commit 39806e3 into bcgov:main Nov 6, 2023
7 checks passed
@dimak1
Copy link
Collaborator

dimak1 commented Nov 6, 2023

Merged as requested by @RuoxuanPengBC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants