Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cancel unit note text on review and confirm screen #1600

Merged
merged 5 commits into from
Oct 30, 2023
Merged

update cancel unit note text on review and confirm screen #1600

merged 5 commits into from
Oct 30, 2023

Conversation

RuoxuanPengBC
Copy link
Contributor

Issue #: /bcgov/entity#18143

Description of changes:

updated cancel unit note text on review and confirm screen dynamically

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@RuoxuanPengBC
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1600-et288yyt.web.app

dimak1
dimak1 requested changes Oct 25, 2023
View reviewed changes
ppr-ui/src/components/unitNotes/UnitNoteReview.vue Outdated
@@ -9,7 +9,8 @@
</p>

<p v-if="isCancelUnitNote" class="mb-15" data-test-id="cancel-note-info">
<b>Note:</b> Once this Cancel Note is registered, the original Notice of Caution will no longer
<b>Note:</b> Once this Cancel Note is registered, the original
{{ getCancelledUnitNoteHeader().replace(/[()]/g,"") }} will no longer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get the unit note info from unitNotes.ts under the resources folder.
E.g. UnitNotesInfo[doc_type_here].header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some modification, please review again, thank you

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #1600 (6fd5a82) into main (9255e77) will increase coverage by 4.97%.
Report is 310 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
+ Coverage   72.35%   77.32%   +4.97%     
==========================================
  Files         307      379      +72     
  Lines       12767     7016    -5751     
  Branches     2630     1121    -1509     
==========================================
- Hits         9237     5425    -3812     
+ Misses       3518     1559    -1959     
- Partials       12       32      +20
Flag Coverage Δ
pprui 77.32% <ø> (+4.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 37 more

... and 278 files with indirect coverage changes

@RuoxuanPengBC RuoxuanPengBC force-pushed the fix/update-cancel-note-text-on-review branch 2 times, most recently from 5dbfd7c to f62949a Compare October 25, 2023 17:50
@RuoxuanPengBC
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1600-et288yyt.web.app

@RuoxuanPengBC RuoxuanPengBC requested a review from dimak1 October 25, 2023 20:41
@RuoxuanPengBC RuoxuanPengBC force-pushed the fix/update-cancel-note-text-on-review branch from f62949a to 3e9af38 Compare October 25, 2023 22:45
dimak1
dimak1 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be great to support the update with a small unit test. Approved anyway.

doug-lovett
doug-lovett approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@RuoxuanPengBC
Copy link
Contributor Author

Looks good. Would be great to support the update with a small unit test. Approved anyway.

@dimak1 working on the tests, thank you

@RuoxuanPengBC RuoxuanPengBC force-pushed the fix/update-cancel-note-text-on-review branch from 3e9af38 to 6ce82de Compare October 27, 2023 16:08
@RuoxuanPengBC
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1600-et288yyt.web.app

@cameron-eyds cameron-eyds merged commit 0b53823 into bcgov:main Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-lovett doug-lovett doug-lovett approved these changes

@dimak1 dimak1 dimak1 approved these changes

@cameron-eyds cameron-eyds Awaiting requested review from cameron-eyds

Assignees

@RuoxuanPengBC RuoxuanPengBC

Labels
MHR Unit Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RuoxuanPengBC @bcregistry-sre @dimak1 @doug-lovett @cameron-eyds