Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update notice of tax remark checkbox wording #1593

Merged
merged 7 commits into from
Oct 24, 2023
Merged

update notice of tax remark checkbox wording #1593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e161822
update notice of tax remark checkbox wording
RuoxuanPengBC Oct 23, 2023
2ee7263
fix on ticket #17647, PR #1587
RuoxuanPengBC Oct 23, 2023
b94bc81
align the checkbox and its label
RuoxuanPengBC Oct 23, 2023
011bf6b
cleanup unused style
RuoxuanPengBC Oct 23, 2023
dec04ed
minor changes on layout
RuoxuanPengBC Oct 24, 2023
e746137
Merge branch 'main' into fix/update-notice-of-tax-remark-checkbox-wor…
RuoxuanPengBC Oct 24, 2023
76ff59f
code exceed length fixing
RuoxuanPengBC Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ppr-ui/src/components/common/Remarks.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<v-form ref="remarksForm" v-model="isFormValid">
<v-card
id="remarks-card"
class="py-6 px-8 rounded"
class="py-10 px-8 rounded"
:class="{ 'border-error-left': showBorderError }"
flat
>
Expand Down Expand Up @@ -35,12 +35,19 @@

<v-checkbox
v-if="showAdditionalRemarksCheckbox"
class="py-0 pr-0 ma-0"
v-model="hasAdditionalRemarks"
:label="content.checkboxLabel"
class="py-0 pr-0 ma-0 mt-n5"
:hide-details="true"
data-test-id="additional-remarks-checkbox"
/>
v-model="hasAdditionalRemarks"
>
<template v-slot:label>
<div class="pt-5">
<span>
{{content.checkboxLabel}}
</span>
</div>
</template>
</v-checkbox>
</v-col>
</v-row>
</v-card>
Expand Down
2 changes: 1 addition & 1 deletion ppr-ui/src/components/mhrTransfers/TransferType.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
:disabled="disableSelect"
:rules="declaredValueRules"
:hint="declaredHomeValueHint"
persistent-hint="true"
:persistent-hint="true"
data-test-id="declared-value"
/>
<span class="mt-4">.00</span>
Expand Down
3 changes: 2 additions & 1 deletion ppr-ui/src/resources/unitNotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ export const remarksContent = {
description: 'Remarks will be shown when a search result is produced for this manufactured home.',
sideLabel: 'Add Remarks',
sideLabelCancelNote: 'Remarks',
checkboxLabel: 'A notice pursuant to section 645/656 of the Local Government Act was filed'
checkboxLabel: 'A notice pursuant to Division 7 of Part 16 of the Local Government Act ' +
'or other applicable legislation has been filed'
}

// List of Unit Notes that can put MHR in Locked state for Qualified Suppliers
Expand Down
7 changes: 6 additions & 1 deletion ppr-ui/tests/unit/UnitNotePanels.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ import {
} from './test-data'
import { BaseAddress } from '@/composables/address'
import { pacificDate, shortPacificDate } from '@/utils'
import { ResidentialExemptionQSDropDown, ResidentialExemptionStaffDropDown, UnitNotesInfo, cancelledWithRedemptionNote } from '@/resources/unitNotes'
import {
ResidentialExemptionQSDropDown,
ResidentialExemptionStaffDropDown,
UnitNotesInfo,
cancelledWithRedemptionNote
} from '@/resources/unitNotes'
import { CancelUnitNoteIF, UnitNoteIF, UnitNotePanelIF } from '@/interfaces'
import { getTestId } from './utils'
import { useMhrUnitNote } from '@/composables'
Expand Down
Loading