Alignment Updates and Exemption Review Unit Tests #1586
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
+ Coverage 72.35% 77.27% +4.92%
==========================================
Files 307 379 +72
Lines 12767 6976 -5791
Branches 2630 1108 -1522
==========================================
- Hits 9237 5391 -3846
+ Misses 3518 1553 -1965
- Partials 12 32 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1586-8vgcs4br.web.app |
| expect(wrapper.findComponent(FolioOrReferenceNumber).exists()).toBe(true) | ||
| }) | ||
|
|
||
| it('renders the ConfirmCompletion section', () => { |
There was a problem hiding this comment.
What's the reason for having them in separate tests? So we can add more assertions as we go on?
There was a problem hiding this comment.
Yea, it's just long-hand i guess. Keep it simple.
|
|
||
| export function setupMockQualifiedSupplier (): void { | ||
| setupMockUser() | ||
| store.setAuthRoles([]) |
There was a problem hiding this comment.
Probably need to specify that this is Lawyer QS.
In my QS tests, I did add [AuthRoles.MHR_TRANSFER_SALE] roles, with a [ProductCode.MANUFACTURER] product codes.
There was a problem hiding this comment.
Sure, can update.
Although the Roles no longer have a part to play, for the UI at least. We should just be relying on the product code.
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1586-8vgcs4br.web.app |
Issue #: /bcgov/entity#17420
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).