Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tooltip text update sale gift transfer #1578

Merged

Conversation

RuoxuanPengBC
Copy link
Contributor

Issue #: /bcgov/entity#17648

Description of changes:

Transfer due to sale or gift dropdown tooltip text updated

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@RuoxuanPengBC
Copy link
Contributor Author

/gcbrun

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1578-gwx9v3ld.web.app

@RuoxuanPengBC
Copy link
Contributor Author

@dimak1 all tests are passed on my device, why the testing-coverage is failed right now. What should I do to fix it?

@cameron-eyds
Copy link
Collaborator

@dimak1 all tests are passed on my device, why the testing-coverage is failed right now. What should I do to fix it?

Sometimes the unit tests timeout, maybe server related? Either way, typically just re-run the tests in this scenario or if the codecov fails to upload etc.

@RuoxuanPengBC
Copy link
Contributor Author

@dimak1 all tests are passed on my device, why the testing-coverage is failed right now. What should I do to fix it?

Sometimes the unit tests timeout, maybe server related? Either way, typically just re-run the tests in this scenario or if the codecov fails to upload etc.

Thanks for your comment, how can i re-run the test?

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1578 (858b8b2) into main (9255e77) will increase coverage by 5.20%.
Report is 285 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
+ Coverage   72.35%   77.55%   +5.20%     
==========================================
  Files         307      377      +70     
  Lines       12767     6880    -5887     
  Branches     2630     1094    -1536     
==========================================
- Hits         9237     5336    -3901     
+ Misses       3518     1512    -2006     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.55% <ø> (+5.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 60 more

... and 254 files with indirect coverage changes

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dimak1 dimak1 merged commit b9caadf into bcgov:main Oct 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants