-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/tooltip text update sale gift transfer #1578
Fix/tooltip text update sale gift transfer #1578
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
Temporary Url for review: https://bcregistry-assets-dev--pr-1578-gwx9v3ld.web.app |
@dimak1 all tests are passed on my device, why the testing-coverage is failed right now. What should I do to fix it? |
Sometimes the unit tests timeout, maybe server related? Either way, typically just re-run the tests in this scenario or if the codecov fails to upload etc. |
Thanks for your comment, how can i re-run the test? |
Codecov Report
@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
+ Coverage 72.35% 77.55% +5.20%
==========================================
Files 307 377 +70
Lines 12767 6880 -5887
Branches 2630 1094 -1536
==========================================
- Hits 9237 5336 -3901
+ Misses 3518 1512 -2006
- Partials 12 32 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Issue #: /bcgov/entity#17648
Description of changes:
Transfer due to sale or gift dropdown tooltip text updated
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).