No Certification checkbox error on MHR Info page

[RuoxuanPengBC]

Issue #: /bcgov/entity#17646

Description of changes:

Changed the logic of selecting which info is rendered.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

[RuoxuanPengBC]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://bcregistry-assets-dev--pr-1577-8tfl0d8g.web.app

[dimak1]

Looks good, but if you could add a unit test would be even better!

[cameron-eyds]

Looks good!
Seconding Dima's comment for a unit test 👍

[codecov]

Codecov Report

Merging #1577 (78cc99a) into main (9255e77) will increase coverage by 4.93%.
Report is 295 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
+ Coverage   72.35%   77.28%   +4.93%     
==========================================
  Files         307      379      +72     
  Lines       12767     6988    -5779     
  Branches     2630     1112    -1518     
==========================================
- Hits         9237     5401    -3836     
+ Misses       3518     1555    -1963     
- Partials       12       32      +20     

Flag	Coverage Δ
pprui	77.28% <ø> (+4.93%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ppr-ui/src/App.vue	100.00% <ø> (+56.78%)	⬆️
ppr-ui/src/components/collateral/Collateral.vue	100.00% <ø> (+10.97%)	⬆️
...nents/collateral/generalCollateral/GenColAmend.vue	100.00% <ø> (+18.00%)	⬆️
...onents/collateral/generalCollateral/GenColEdit.vue	100.00% <ø> (+15.15%)	⬆️
...nts/collateral/generalCollateral/GenColSummary.vue	100.00% <ø> (+8.00%)	⬆️
...collateral/generalCollateral/GeneralCollateral.vue	100.00% <ø> (+6.66%)	⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue	100.00% <ø> (+22.58%)	⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue	100.00% <ø> (+19.41%)	⬆️
...cleCollateral/factories/useCollateralValidation.ts	71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts	70.14% <ø> (-0.91%)	⬇️
... and 41 more

... and 274 files with indirect coverage changes

[RuoxuanPengBC]

@dimak1 @cameron-eyds Thank you so much for your comments. I will work on the unit test soon. It may take some time for me to create one.

[dimak1]

@dimak1 @cameron-eyds Thank you so much for your comments. I will work on the unit test soon. It may take some time for me to create one.

@RuoxuanPengBC, there might already be unit tests created for that page. You can just add additional checks. If you need help, let me know!

[doug-lovett]

Looks good

[RuoxuanPengBC]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://bcregistry-assets-dev--pr-1577-8tfl0d8g.web.app

[RuoxuanPengBC]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://bcregistry-assets-dev--pr-1577-8tfl0d8g.web.app