Skip to content

Commit

Permalink
update notice of tax remark checkbox wording (#1593)
Browse files Browse the repository at this point in the history
* update notice of tax remark checkbox wording
* fix on ticket #17647, PR #1587
* align the checkbox and its label
  • Loading branch information
RuoxuanPengBC authored Oct 24, 2023
1 parent d09bc07 commit ce5dc70
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 8 deletions.
17 changes: 12 additions & 5 deletions ppr-ui/src/components/common/Remarks.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<v-form ref="remarksForm" v-model="isFormValid">
<v-card
id="remarks-card"
class="py-6 px-8 rounded"
class="py-10 px-8 rounded"
:class="{ 'border-error-left': showBorderError }"
flat
>
Expand Down Expand Up @@ -35,12 +35,19 @@

<v-checkbox
v-if="showAdditionalRemarksCheckbox"
class="py-0 pr-0 ma-0"
v-model="hasAdditionalRemarks"
:label="content.checkboxLabel"
class="py-0 pr-0 ma-0 mt-n5"
:hide-details="true"
data-test-id="additional-remarks-checkbox"
/>
v-model="hasAdditionalRemarks"
>
<template v-slot:label>
<div class="pt-5">
<span>
{{content.checkboxLabel}}
</span>
</div>
</template>
</v-checkbox>
</v-col>
</v-row>
</v-card>
Expand Down
2 changes: 1 addition & 1 deletion ppr-ui/src/components/mhrTransfers/TransferType.vue
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
:disabled="disableSelect"
:rules="declaredValueRules"
:hint="declaredHomeValueHint"
persistent-hint="true"
:persistent-hint="true"
data-test-id="declared-value"
/>
<span class="mt-4">.00</span>
Expand Down
3 changes: 2 additions & 1 deletion ppr-ui/src/resources/unitNotes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ export const remarksContent = {
description: 'Remarks will be shown when a search result is produced for this manufactured home.',
sideLabel: 'Add Remarks',
sideLabelCancelNote: 'Remarks',
checkboxLabel: 'A notice pursuant to section 645/656 of the Local Government Act was filed'
checkboxLabel: 'A notice pursuant to Division 7 of Part 16 of the Local Government Act ' +
'or other applicable legislation has been filed'
}

// List of Unit Notes that can put MHR in Locked state for Qualified Suppliers
Expand Down
7 changes: 6 additions & 1 deletion ppr-ui/tests/unit/UnitNotePanels.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ import {
} from './test-data'
import { BaseAddress } from '@/composables/address'
import { pacificDate, shortPacificDate } from '@/utils'
import { ResidentialExemptionQSDropDown, ResidentialExemptionStaffDropDown, UnitNotesInfo, cancelledWithRedemptionNote } from '@/resources/unitNotes'
import {
ResidentialExemptionQSDropDown,
ResidentialExemptionStaffDropDown,
UnitNotesInfo,
cancelledWithRedemptionNote
} from '@/resources/unitNotes'
import { CancelUnitNoteIF, UnitNoteIF, UnitNotePanelIF } from '@/interfaces'
import { getTestId } from './utils'
import { useMhrUnitNote } from '@/composables'
Expand Down

0 comments on commit ce5dc70

Please sign in to comment.