Cleanup code

bcgov · Jan 23, 2024 · baf4cfc · baf4cfc
1 parent 081ff2d
commit baf4cfc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/ppr-ui/src/components/mhrTransfers/LocationChange.vue b/ppr-ui/src/components/mhrTransfers/LocationChange.vue
@@ -187,15 +187,6 @@ const state = reactive({
       : locationChangeTypes),
   isTransportPermitType: computed(() => state.locationChangeType === LocationChangeTypes.TRANSPORT_PERMIT),
   isNotManufacturersLot: computed(() => getMhrRegistrationLocation.locationType !== HomeLocationTypes.LOT),
-  homeCivicAddress: {
-    street: '',
-    streetAdditional: '',
-    city: '',
-    region: '',
-    postalCode: '',
-    country: '',
-    deliveryInstructions: ''
-  },
   showChangeTransportPermitLocationTypeDialog: false
 })
 

diff --git a/ppr-ui/src/views/mhrInformation/MhrInformation.vue b/ppr-ui/src/views/mhrInformation/MhrInformation.vue
@@ -625,6 +625,7 @@ export default defineComponent({
       isValidTransfer,
       isValidTransferReview,
       isValidTransportPermit,
+      isValidTransportPermitReview,
       scrollToFirstError,
       resetValidationState
     } = useMhrInfoValidation(getMhrInfoValidation.value)
@@ -719,15 +720,16 @@ export default defineComponent({
           return '< Lien on this home is preventing transfer'
         }
 
+        let isValidReview
+
         if (isChangeLocationActive.value) {
           // transport permit activated
-          const isValidReview = localState.isReviewMode ? isValidTransportPermit.value : isValidTransportPermit.value
-          return localState.validate && !isValidReview ? '< Please complete required information' : ''
+          isValidReview = localState.isReviewMode ? isValidTransportPermitReview.value : isValidTransportPermit.value
         } else {
-          const isValidReview = localState.isReviewMode ? isValidTransferReview.value : isValidTransfer.value
-          return localState.validate && !isValidReview ? '< Please complete required information' : ''
+          isValidReview = localState.isReviewMode ? isValidTransferReview.value : isValidTransfer.value
         }
 
+        return localState.validate && !isValidReview ? '< Please complete required information' : ''
       }),
       reviewConfirmText: computed((): string => {
         return localState.isReviewMode ? 'Register Changes and Pay' : 'Review and Confirm'