Fixed ld key access

bcgov · Dec 18, 2024 · b0077ba · b0077ba
1 parent 0ea2a5c
commit b0077ba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/ppr-ui/src/plugins/init.ts b/ppr-ui/src/plugins/init.ts
@@ -8,7 +8,7 @@ export default defineNuxtPlugin(async (nuxtApp) => {
   // initialize Launch Darkly
   if (useRuntimeConfig().public.VUE_APP_PPR_LD_CLIENT_ID) {
     console.info('Initializing Launch Darkly...')
-    await initLdClient()
+    await initLdClient(useRuntimeConfig().public.VUE_APP_PPR_LD_CLIENT_ID)
   }
 
   // Local development only

diff --git a/ppr-ui/src/utils/config-helper.ts b/ppr-ui/src/utils/config-helper.ts
@@ -72,11 +72,6 @@ export async function fetchConfig (): Promise<any> {
     sessionStorage.setItem('ACCOUNT_ID', accountId)
   }
 
-  const ldClientId: string = config.VUE_APP_PPR_LD_CLIENT_ID
-  if (ldClientId) {
-    (<any>window).ldClientId = ldClientId
-  }
-
   const pprStaffPartyCode: string = config.VUE_APP_PPR_STAFF_PARTY_CODE
   if (pprStaffPartyCode) {
     sessionStorage.setItem('PPR_STAFF_PARTY_CODE', pprStaffPartyCode)

diff --git a/ppr-ui/src/utils/feature-flags.ts b/ppr-ui/src/utils/feature-flags.ts
@@ -1,4 +1,5 @@
-import { initialize, LDClient, LDFlagSet, LDOptions, LDUser } from 'launchdarkly-js-client-sdk'
+import type { LDClient, LDFlagSet, LDOptions, LDUser } from 'launchdarkly-js-client-sdk';
+import { initialize } from 'launchdarkly-js-client-sdk'
 
 /**
  * Default feature flags in case LD env key is not defined (eg, local development).
@@ -36,9 +37,7 @@ let ldClient: LDClient = null
 /**
  * An async method that initializes the Launch Darkly client.
  */
-export async function initLdClient (): Promise<void> {
-  const envKey: string = window['ldClientId'] // eslint-disable-line dot-notation
-
+export async function initLdClient (envKey: string): Promise<void> {
   if (envKey) {
     const user: LDUser = {
       // since we have no user data yet, use a shared key temporarily