Modernized Linting for Vue and Typescript -- Applied non functional f…

…ixes
bcgov · Oct 24, 2023 · 7737d2b · 7737d2b
1 parent 4d2609a
commit 7737d2b
Show file tree

Hide file tree

Showing 180 changed files with 9,347 additions and 4,290 deletions.
diff --git a/ppr-ui/.eslintrc.js b/ppr-ui/.eslintrc.js
@@ -5,12 +5,9 @@ module.exports = {
     es2022: true
   },
   extends: [
-    'plugin:vue/essential',
-    '@vue/standard',
-    '@vue/typescript',
-    'plugin:vue/base',
     'plugin:vuetify/base',
-    'plugin:vuetify/recommended'
+    'plugin:vue/vue3-recommended',
+    '@vue/typescript/recommended'
   ],
   rules: {
     'standard/computed-property-even-spacing': 'off',
@@ -21,8 +18,9 @@ module.exports = {
     'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off',
     'max-len': ['warn', { code: 120, ignoreRegExpLiterals: true }]
   },
+  parser: "vue-eslint-parser",
   parserOptions: {
-    parser: '@typescript-eslint/parser',
-    plugins: ['@typescript-eslint']
+    parser: "@typescript-eslint/parser",
+    sourceType: "module"
   }
 }
diff --git a/ppr-ui/package.json b/ppr-ui/package.json
@@ -8,7 +8,7 @@
     "dev": "vite",
     "build": "vite build",
     "serve": "vite preview",
-    "lint": "eslint . --ext .js,.ts,.vue",
+    "lint": "eslint --fix . --ext .js,.ts,.vue",
     "test:unit": "vitest run",
     "test:coverage": "vitest run --coverage"
   },

diff --git a/ppr-ui/src/App.vue b/ppr-ui/src/App.vue
@@ -1,32 +1,35 @@
 <template>
-  <v-app class="app-container" id="app">
+  <v-app
+    id="app"
+    class="app-container"
+  >
     <!-- Dialogs -->
     <BaseDialog
       id="errorDialogApp"
-      :setDisplay="errorDisplay"
-      :setOptions="errorOptions"
+      :set-display="errorDisplay"
+      :set-options="errorOptions"
       @proceed="proceedAfterError"
     />
     <BaseDialog
       id="payErrorDialogApp"
-      :setDisplay="payErrorDisplay"
-      :setOptions="payErrorOptions"
+      :set-display="payErrorDisplay"
+      :set-options="payErrorOptions"
       @proceed="payErrorDialogHandler($event)"
     />
     <!-- Application Header -->
     <SbcHeader
-        class="sbc-header"
-        :in-auth="false"
-        :show-login-menu="false"
-      />
+      class="sbc-header"
+      :in-auth="false"
+      :show-login-menu="false"
+    />
 
     <div class="app-body">
       <main>
         <sbc-system-banner
           v-if="bannerText != null"
-          v-bind:show="bannerText != null"
-          v-bind:type="null"
-          v-bind:message="bannerText"
+          :show="bannerText != null"
+          :type="null"
+          :message="bannerText"
           icon=" "
         />
         <Breadcrumb v-if="haveData" />
@@ -35,11 +38,11 @@
           <v-row no-gutters>
             <v-col cols="12">
               <router-view
-                :appLoadingData="!haveData"
-                :appReady="appReady"
-                :isJestRunning="isJestRunning"
-                :saveDraftExit="saveDraftExitToggle"
-                :registryUrl="registryUrl"
+                :app-loading-data="!haveData"
+                :app-ready="appReady"
+                :is-jest-running="isJestRunning"
+                :save-draft-exit="saveDraftExitToggle"
+                :registry-url="registryUrl"
                 @profileReady="profileReady = true"
                 @error="handleError($event)"
                 @haveData="haveData = $event"
@@ -50,7 +53,7 @@
       </main>
     </div>
 
-    <sbc-footer :aboutText=aboutText />
+    <sbc-footer :about-text="aboutText" />
   </v-app>
 </template>
 

diff --git a/ppr-ui/src/assets/svgs/ExecutorBusinessIcon.vue b/ppr-ui/src/assets/svgs/ExecutorBusinessIcon.vue
@@ -1,14 +1,35 @@
 <template>
-  <svg width="25" height="17" viewBox="0 0 25 17" fill="none" xmlns="http://www.w3.org/2000/svg">
-    <path fill-rule="evenodd" clip-rule="evenodd" d="M6 1H14.8889V4.55556H23.7778V17H6V1ZM7.77778
+  <svg
+    width="25"
+    height="17"
+    viewBox="0 0 25 17"
+    fill="none"
+    xmlns="http://www.w3.org/2000/svg"
+  >
+    <path
+      fill-rule="evenodd"
+      clip-rule="evenodd"
+      d="M6 1H14.8889V4.55556H23.7778V17H6V1ZM7.77778
       4.55556H9.55556V2.77778H7.77778V4.55556ZM11.3333 4.55556H13.1111V2.77778H11.3333V4.55556ZM21.9997
       15.2222H14.8886V13.4444H16.6664V11.6667H14.8886V9.88889H16.6664V8.11111H14.8886V6.33333H21.9997V15.2222ZM18.4444
       8.11111H20.2222V9.88889H18.4444V8.11111ZM18.4444 11.6667H20.2222V13.4444H18.4444V11.6667ZM13.1111
       8.11111H11.3333V6.33333H13.1111V8.11111ZM11.3333 11.6667H13.1111V9.88889H11.3333V11.6667ZM13.1111
       15.2222H11.3333V13.4444H13.1111V15.2222ZM9.55556 8.11111H7.77778V6.33333H9.55556V8.11111ZM7.77778
-      11.6667H9.55556V9.88889H7.77778V11.6667ZM9.55556 15.2222H7.77778V13.4444H9.55556V15.2222Z" fill="#212529"/>
-      <circle cx="6" cy="5" r="5" fill="white"/>
-    <path fill-rule="evenodd" clip-rule="evenodd" d="M6 7.09L3.55 8.58L4.2 5.77L2 3.89L4.89 3.64L6 1L7.13 3.64L10
-      3.89L7.82 5.77L8.5 8.58L6 7.09Z" fill="#212529"/>
+      11.6667H9.55556V9.88889H7.77778V11.6667ZM9.55556 15.2222H7.77778V13.4444H9.55556V15.2222Z"
+      fill="#212529"
+    />
+    <circle
+      cx="6"
+      cy="5"
+      r="5"
+      fill="white"
+    />
+    <path
+      fill-rule="evenodd"
+      clip-rule="evenodd"
+      d="M6 7.09L3.55 8.58L4.2 5.77L2 3.89L4.89 3.64L6 1L7.13 3.64L10
+      3.89L7.82 5.77L8.5 8.58L6 7.09Z"
+      fill="#212529"
+    />
   </svg>
 </template>
diff --git a/ppr-ui/src/assets/svgs/ExecutorPersonIcon.vue b/ppr-ui/src/assets/svgs/ExecutorPersonIcon.vue
@@ -1,7 +1,18 @@
 <template>
-  <svg width="22" height="16" viewBox="0 0 22 16" fill="none" xmlns="http://www.w3.org/2000/svg">
-    <path fill-rule="evenodd" clip-rule="evenodd" d="M14 8C16.2091 8 18 6.20914 18 4C18 1.79086 16.2091 0 14 0C11.7909
+  <svg
+    width="22"
+    height="16"
+    viewBox="0 0 22 16"
+    fill="none"
+    xmlns="http://www.w3.org/2000/svg"
+  >
+    <path
+      fill-rule="evenodd"
+      clip-rule="evenodd"
+      d="M14 8C16.2091 8 18 6.20914 18 4C18 1.79086 16.2091 0 14 0C11.7909
       0 10 1.79086 10 4C10 6.20914 11.7909 8 14 8ZM14 10C11.33 10 6 11.33 6 14V16H22V14C22 11.33 16.67 10 14 10ZM6.45
-      10.77L4 9.28L1.5 10.77L2.18 7.96L0 6.08L2.87 5.83L4 3.19L5.11 5.83L8 6.08L5.8 7.96L6.45 10.77Z" fill="#212529"/>
+      10.77L4 9.28L1.5 10.77L2.18 7.96L0 6.08L2.87 5.83L4 3.19L5.11 5.83L8 6.08L5.8 7.96L6.45 10.77Z"
+      fill="#212529"
+    />
   </svg>
 </template>
diff --git a/ppr-ui/src/assets/svgs/HomeLocationIcon.vue b/ppr-ui/src/assets/svgs/HomeLocationIcon.vue
@@ -8,24 +8,41 @@
     xmlns:xlink="http://www.w3.org/1999/xlink"
   >
     <title>home location</title>
-    <g id="Final-MHR-Registration-MVP" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
-        <g id="custom-icons" transform="translate(-55.000000, -107.000000)" fill="#1669BB" fill-rule="nonzero">
-            <g id="home-location" transform="translate(55.000000, 107.000000)">
-                <path d="M13,0 L21.9343063,8.00361469 C18.7548668,9.23354879 16.5,12.3204293 16.5,15.9339623 C16.5,
+    <g
+      id="Final-MHR-Registration-MVP"
+      stroke="none"
+      stroke-width="1"
+      fill="none"
+      fill-rule="evenodd"
+    >
+      <g
+        id="custom-icons"
+        transform="translate(-55.000000, -107.000000)"
+        fill="#1669BB"
+        fill-rule="nonzero"
+      >
+        <g
+          id="home-location"
+          transform="translate(55.000000, 107.000000)"
+        >
+          <path
+            id="Combined-Shape"
+            d="M13,0 L21.9343063,8.00361469 C18.7548668,9.23354879 16.5,12.3204293 16.5,15.9339623 C16.5,
                   18.3101315 17.4750157,20.4585737 19.0467929,22.0010345 L3.9,22 L3.9,11.6470588 L0,11.6470588 L13,0 Z"
-                  id="Combined-Shape">
-                </path>
-                <path d="M23.6738432,16.861235 C22.6392602,16.861235 21.800565,16.0539908 21.800565,15.0582047
+          />
+          <path
+            id="Shape"
+            d="M23.6738432,16.861235 C22.6392602,16.861235 21.800565,16.0539908 21.800565,15.0582047
                   21.800565,14.5800113 21.9979277,14.1214035 22.3492355,13.7832697 C22.7005433,13.445136 23.1770189,
                   13.2551744 23.6738432,13.2551744 C24.7084262,13.2551744 25.5471215,14.0624185 25.5471215,15.0582047
                   C25.5471215,15.5363981 25.3497588,15.9950059 24.998451,16.3331396 C24.6471432,16.6712734 24.1706675,
                   16.861235 23.6738432,16.861235 M23.6738432,10.0097198 C20.7770108,10.0097198 18.4286642,12.2700035
                   18.4286642,15.0582047 C18.4286642,18.8445683 23.6738432,24.4339623 23.6738432,24.4339623 C23.6738432,
                   24.4339623 28.9190223,18.8445683 28.9190223,15.0582047 C28.9190223,12.2700035 26.5706756,10.0097198
-                  23.6738432,10.0097198 L23.6738432,10.0097198 Z" id="Shape">
-                </path>
-            </g>
+                  23.6738432,10.0097198 L23.6738432,10.0097198 Z"
+          />
         </g>
+      </g>
     </g>
   </svg>
 </template>
diff --git a/ppr-ui/src/assets/svgs/HomeOwnersIcon.vue b/ppr-ui/src/assets/svgs/HomeOwnersIcon.vue
@@ -8,24 +8,41 @@
     xmlns:xlink="http://www.w3.org/1999/xlink"
   >
     <title>home owner</title>
-    <g id="Final-MHR-Registration-MVP" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
-        <g id="custom-icons" transform="translate(-154.000000, -164.000000)" fill="#1669BB" fill-rule="nonzero">
-            <g id="single-owner" transform="translate(154.000000, 164.000000)">
-                <path d="M13,0 L23.341033,9.26375998 C22.9859677,9.18151424 22.6160473,9.13804071 22.2359732,9.13804071
+    <g
+      id="Final-MHR-Registration-MVP"
+      stroke="none"
+      stroke-width="1"
+      fill="none"
+      fill-rule="evenodd"
+    >
+      <g
+        id="custom-icons"
+        transform="translate(-154.000000, -164.000000)"
+        fill="#1669BB"
+        fill-rule="nonzero"
+      >
+        <g
+          id="single-owner"
+          transform="translate(154.000000, 164.000000)"
+        >
+          <path
+            id="Combined-Shape"
+            d="M13,0 L23.341033,9.26375998 C22.9859677,9.18151424 22.6160473,9.13804071 22.2359732,9.13804071
                   C19.5422646,9.13804071 17.3585823,11.321723 17.3585823,14.0154316 C17.3585823,15.3976762 17.9335693,
                   16.6456254 18.8574077,17.5331435 L18.6903626,17.5333325 C16.4812236,17.5333325 14.6903626,19.3241935
                   14.6903626,21.5333325 L14.6903626,21.5333325 L14.69,22 L3.9,22 L3.9,11.6470588 L0,11.6470588 L13,0 Z"
-                  id="Combined-Shape">
-                </path>
-                <path d="M22.7237123,11.0889971 C24.4746229,11.0889971 25.8940163,12.5083905 25.8940163,14.2593011
+          />
+          <path
+            id="Shape"
+            d="M22.7237123,11.0889971 C24.4746229,11.0889971 25.8940163,12.5083905 25.8940163,14.2593011
                   C25.8940163,16.0102117 24.4746229,17.4296052 22.7237123,17.4296052 C20.9728017,17.4296052 19.5534082,
                   16.0102117 19.5534082,14.2593011 C19.5534082,12.5083905 20.9728017,11.0889971 22.7237123,11.0889971
                   M22.7237123,19.0147572 C26.2268983,19.0147572 29.0643204,20.4334683 29.0643204,22.1850613 L29.0643204,
                   23.7702133 L16.3831041,23.7702133 L16.3831041,22.1850613 C16.3831041,20.4334683 19.2205263,19.0147572
-                  22.7237123,19.0147572 Z" id="Shape">
-                </path>
-            </g>
+                  22.7237123,19.0147572 Z"
+          />
         </g>
+      </g>
     </g>
   </svg>
 </template>