minor syntax fix and error handling

bcgov · Dec 6, 2023 · 4c83972 · 4c83972
1 parent 5668e83
commit 4c83972
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 14 deletions.
diff --git a/ppr-ui/src/App.vue b/ppr-ui/src/App.vue
@@ -613,9 +613,7 @@ export default defineComponent({
     const proceedAfterError = (proceed: boolean): void => {
       localState.errorDisplay = false
       // Navigate to Registries dashboard in the event of a login or access error.
-      if (localState.errorOptions === loginError || localState.errorOptions === authPprError ||
-        localState.errorOptions === authAssetsError
-      ) {
+      if ([loginError.title, authPprError.title, authAssetsError.title].includes(localState.errorOptions.title)) {
         navigateTo(localState.registryUrl)
       }
       // for now just refresh app

diff --git a/ppr-ui/src/components/tables/common/TableRow.vue b/ppr-ui/src/components/tables/common/TableRow.vue
@@ -520,10 +520,10 @@
                     content-class="left-tooltip pa-5"
                     transition="fade-transition"
                   >
-                    <template #activator="{ on }">
+                    <template #activator="{ props }">
                       <span
                         class="disabled-text"
-                        v-on="on"
+                        v-bind="props"
                       >
                         <img
                           alt="exemption-icon"
@@ -748,14 +748,14 @@ export default defineComponent({
         return (isRoleQualifiedSupplier.value || isRoleStaffReg.value || isRoleStaff.value) &&
           !isRoleStaffSbc.value && !isRoleStaffBcol.value
       }),
-      hasLienForQS: computed(() =>
-        isRoleQualifiedSupplier.value &&
-        localState.item.lienRegistrationType &&
-        localState.item.lienRegistrationType !== APIRegistrationTypes.SECURITY_AGREEMENT
-      ),
-      hasLockedForQS: computed(() =>
-        hasLockedState(localState.item) && isRoleQualifiedSupplier.value
-      )
+      hasLienForQS: computed(() => {
+        return isRoleQualifiedSupplier.value &&
+          localState.item.lienRegistrationType &&
+          localState.item.lienRegistrationType !== APIRegistrationTypes.SECURITY_AGREEMENT
+      }),
+      hasLockedForQS: computed(() => {
+       return  hasLockedState(localState.item) && isRoleQualifiedSupplier.value
+      })
     })
 
     const hasRequiredTransfer = (item: MhRegistrationSummaryIF) => {

diff --git a/ppr-ui/src/main.ts b/ppr-ui/src/main.ts
@@ -21,7 +21,7 @@ declare const window: any
 
 // main code
 async function start () {
-  console.log('Starting app from main...') // eslint-disable-line no-console
+  console.log('Starting app...')
   // fetch config from environment and API
   // must come first as inits below depend on config
   await fetchConfig()