Skip to content

Commit

Permalink
replaced condition to validate on click review button (#2012)
Browse files Browse the repository at this point in the history
  • Loading branch information
flutistar authored Aug 27, 2024
1 parent 1ec5cf0 commit 20d75a7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
4 changes: 2 additions & 2 deletions ppr-ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ppr-ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ppr-ui",
"version": "3.2.49",
"version": "3.2.50",
"private": true,
"appName": "Assets UI",
"sbcName": "SBC Common Components",
Expand Down
8 changes: 3 additions & 5 deletions ppr-ui/src/views/newMhrRegistration/HomeOwners.vue
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ import {
} from '@/composables'
import { MhrRegistrationHomeOwnerGroupIF } from '@/interfaces'
import { ActionTypes, RouteNames } from '@/enums'
import { ActionTypes, RouteNames, UITransferTypes } from '@/enums'
import { transfersErrors } from '@/resources'
import { formatCurrency } from '@/utils'
Expand Down Expand Up @@ -497,13 +497,11 @@ export default defineComponent({
enableHomeOwnerChanges,
enableAddHomeOwners,
enableDeleteAllGroupsActions,
isTransferToSurvivingJointTenant,
isTransferDueToDeath,
isTransferToExecutorProbateWill,
isTransferToExecutorUnder25Will,
isTransferToAdminNoWill,
TransToExec,
TransJointTenants
} = useTransferOwners(!props.isMhrTransfer)
const {
Expand Down Expand Up @@ -599,8 +597,8 @@ export default defineComponent({
}),
changesRequired: computed((): boolean => {
// If the transfer type is "Transfer to Surviving Joint Tenant(s)", at least one owners needs to be removed
if(isTransferToSurvivingJointTenant.value){
return !TransJointTenants.isValidTransfer.value
if(getUiTransferType() === UITransferTypes.SURVIVING_JOINT_TENANT){
return props.validateTransfer && !localState.hasRemovedOwners
}
return props.validateTransfer && !hasUnsavedChanges.value
}),
Expand Down

0 comments on commit 20d75a7

Please sign in to comment.