Skip to content

Commit

Permalink
Mhr History Feedback items (#1974)
Browse files Browse the repository at this point in the history
* minor history uxa

* disable codecov failure
  • Loading branch information
cameron-eyds authored Jul 9, 2024
1 parent fdfb0fe commit 1497964
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ppr-ui-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
with:
flags: pprui
name: codecov-ppr-ui
fail_ci_if_error: true
fail_ci_if_error: false

build-check:
needs: setup-job
Expand Down
8 changes: 8 additions & 0 deletions ppr-ui/src/components/common/SimpleTable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
<td
v-for="(header, colIndex) in tableHeaders"
:key="`cell-${rowIndex}-${colIndex}`"
class="pt-6"
:class="{
'btn-cell' : colIndex === 0,
'font-weight-bold gray9' : colIndex === 1,
'expanded-row-cell' : expandRow[rowIndex]
}"
Expand Down Expand Up @@ -154,9 +156,15 @@ const getItemValue = (item: object, valuePaths: Array<string> | string): string
.expanded-row-cell {
border-bottom: 0!important;
}
.btn-cell {
padding-top: 14px!important;
}
.hide-show-chevron {
background-color: $app-blue;
border-radius: 50%;
color: white;
}
:deep(td) {
align-content: flex-start;
}
</style>
4 changes: 2 additions & 2 deletions ppr-ui/src/components/tombstone/Tombstone.vue
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ export default defineComponent({
}),
displayTombstoneDynamic: computed((): boolean => {
return isMhrCorrection.value || isMhrReRegistration.value ||
['discharge', 'renew', 'amend', 'mhr-information', 'exemption']
['discharge', 'renew', 'amend', 'mhr-information', 'exemption', 'mhr-history']
.some(path => localState.currentPath.includes(path))
}),
displayMhrInformation: computed((): boolean => {
return ['mhr-information', 'exemption'].some(path => localState.currentPath.includes(path))
return ['mhr-information', 'exemption', 'mhr-history'].some(path => localState.currentPath.includes(path))
})
})
Expand Down

0 comments on commit 1497964

Please sign in to comment.